-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Example code for circuit sharing/pausing and smart EV charger #152
Conversation
JingWang-CUB
commented
Nov 18, 2024
•
edited by mnblonsky
Loading
edited by mnblonsky
- Reference the issue your PR is fixing: Circuit sharing and pausing control for panels project TEA #118
- Assign at least 1 reviewer for your PR
- Test with run_dwelling.py or other script
- Update documentation as appropriate
- Update changelog as appropriate
This PR is ready for review, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think a few things should be removed to keep this example simple and useful for other users. Ideally we'd limit this to 2-3 cases that can be run without additional data or files. I also think we could rename the file to run_panel_controls.py
or something like that.
I'm not sure where the project code should live long term, but it seems like keeping it in OCHRE (either merged or in a stale branch) would not be a good precedent for other projects. Maybe a "OCHRE-examples" repo, that could be public or private?
No need to run test scripts or update docs/changelog, since this doesn't modify source code. |
…ions when standby
All required changes have been made. Let me know if you have additional comments. Thanks! |
The changes look great. I made a couple of other changes:
|
The results look good to me! |