Slope fix #36
Merged
Slope fix #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Modifications in Line to apply reduced weight per unit length for Line objects with one end out of the water. These are a rough job and may best be replaced with an improved depth-aware Catenary function in the future.
- Seabed slope for each Line is now calculated based on the depth beneath each endpoint (assuming a uniformly sloped seabed underneath the line) rather than looking at the panel slope under end A. - This should be more robust by avoiding inconsistencies when lines cross panels, though could reduce accuracy for finer grids with Lines that only slightly touch.
- Adjusted drawLine methdos to now draw the shadow on the seabed bathymetry grid if it exists.
- Included a function in subsystem.py to pull from the global bathymetry and produce a 2D bathymetry directly underneath the subsystem - - The bathGrid variable now becomes a 1D array of depths along the subsystem - - bathGrid_Ys become 0, and the xs are set as the nodes along each line in the subsystem - - This way, the alpha (slope) is calculated for each line in the subsystem's line list properly - This function is called every time subsystem.staticSolve is called, with updated bathymetry based on any new rA/rB positions - Additional work to do - - Make sure the global bathymetry is tracked properly (currently needs self.sys != None) - - Ensure the seabedMod parameter is set up properly
|
Overall supporting more cases considering bathymetry. Added a commit myself to have subsystems work with bathymetry. More work still to do related, but can integrate into dev. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few updates related to seabed slope to consider integrating into dev