-
Notifications
You must be signed in to change notification settings - Fork 398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Windows CI Warnings/Messages #8054
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nealkruis
added
Defect
Includes code to repair a defect in EnergyPlus
DoNotPublish
Includes changes that shouldn't be reported in the changelog
labels
Jun 5, 2020
Once CI comes back clean, this can go in as far as I can tell. It's marked draft. Please unmark if it's not draft anymore. |
nealkruis
changed the title
Fix libtess2 build warning
Fix Windows CI Warnings/Messages
Jun 10, 2020
Oh hey there perfectly green CI results. W00t! This is a great fix. Thanks @nealkruis ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Defect
Includes code to repair a defect in EnergyPlus
DoNotPublish
Includes changes that shouldn't be reported in the changelog
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request overview
This updates Penumbra to v0.3.3 to clean up compiler warnings. A PR with the change has been issued in the third party dependency.
Cleaned up CMake warnings and compiler warnings. Removed the warning level override and resolved the previously silenced warnings in "third party" libraries. I did not touch any of the source code in the independent third party libraries (e.g., expat and zlib). A lot of fixes were made by moving CXX compiler definitions to general compiler options (since many of the third party libraries are in C).
Pull Request Author
Add to this list or remove from it as applicable. This is a simple templated set of guidelines.
Reviewer
This will not be exhaustively relevant to every PR.