Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Windows CI Warnings/Messages #8054

Merged
merged 10 commits into from
Jun 15, 2020

Conversation

nealkruis
Copy link
Member

@nealkruis nealkruis commented Jun 5, 2020

Pull request overview

This updates Penumbra to v0.3.3 to clean up compiler warnings. A PR with the change has been issued in the third party dependency.

Cleaned up CMake warnings and compiler warnings. Removed the warning level override and resolved the previously silenced warnings in "third party" libraries. I did not touch any of the source code in the independent third party libraries (e.g., expat and zlib). A lot of fixes were made by moving CXX compiler definitions to general compiler options (since many of the third party libraries are in C).

Pull Request Author

Add to this list or remove from it as applicable. This is a simple templated set of guidelines.

  • Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)
  • Label the PR with at least one of: Defect, Refactoring, NewFeature, Performance, and/or DoNoPublish
  • Author should provide a "walkthrough" of relevant code changes using a GitHub code review comment process

Reviewer

This will not be exhaustively relevant to every PR.

  • Perform a Code Review on GitHub
  • If branch is behind develop, merge develop and build locally to check for side effects of the merge
  • If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • CI status: all green or justified
  • Check that performance is not impacted (CI Linux results include performance check)

@nealkruis nealkruis added Defect Includes code to repair a defect in EnergyPlus DoNotPublish Includes changes that shouldn't be reported in the changelog labels Jun 5, 2020
@nealkruis nealkruis self-assigned this Jun 5, 2020
@Myoldmopar
Copy link
Member

Once CI comes back clean, this can go in as far as I can tell. It's marked draft. Please unmark if it's not draft anymore.

@nealkruis nealkruis changed the title Fix libtess2 build warning Fix Windows CI Warnings/Messages Jun 10, 2020
@mjwitte mjwitte removed the Defect Includes code to repair a defect in EnergyPlus label Jun 10, 2020
@nealkruis nealkruis marked this pull request as ready for review June 12, 2020 02:04
@nealkruis nealkruis requested a review from Myoldmopar June 12, 2020 02:04
@nealkruis nealkruis added the Defect Includes code to repair a defect in EnergyPlus label Jun 12, 2020
@nealkruis nealkruis linked an issue Jun 12, 2020 that may be closed by this pull request
@Myoldmopar
Copy link
Member

image

Oh hey there perfectly green CI results. W00t! This is a great fix. Thanks @nealkruis !

@Myoldmopar Myoldmopar merged commit 6205345 into NREL:develop Jun 15, 2020
@nealkruis nealkruis deleted the fix-windows-ci-warnings branch June 15, 2020 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Defect Includes code to repair a defect in EnergyPlus DoNotPublish Includes changes that shouldn't be reported in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Windows CI issues size_t to unsigned int conversion warning in libtess2 Windows CI Warnings/Messages
8 participants