Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Semantic Graph Synthesis #331

Open
wants to merge 79 commits into
base: develop
Choose a base branch
from
Open

Semantic Graph Synthesis #331

wants to merge 79 commits into from

Conversation

gtfierro
Copy link
Collaborator

@gtfierro gtfierro commented Jul 3, 2024

Got this branch up-to-date with develop. Filing this as a draft PR so we can track progress on it

haneslinger and others added 28 commits September 12, 2023 15:32
…is going on.

# Aider chat conversation:

USER: add to the 'unify_bindings' function comments that explain what is going on

ASSISTANT: To add comments to the 'unify_bindings' function, we need to modify `buildingmotif/semantic_graph_synthesizer/bindings_utils.py`:

1. Add comments to the 'unify_bindings' function to explain what is going on.

Here is the *SEARCH/REPLACE* block:

buildingmotif/semantic_graph_synthesizer/bindings_utils.py
```python
<<<<<<< SEARCH
def unify_bindings(bindings_list: List[Bindings]) -> List[UnifiedBindings]:
    """Combine all the bindings for the same template with the same name"""
=======
def unify_bindings(bindings_list: List[Bindings]) -> List[UnifiedBindings]:
    """
    Combine all the bindings for the same template with the same name.

    This function takes a list of Bindings objects and combines those that have the same template and name.
    The result is a list of UnifiedBindings objects, where each object represents a unique combination of template and name.
    The labels and bindings of the original Bindings objects are merged into the corresponding UnifiedBindings object.
    """
>>>>>>> REPLACE
```
This change adds a more detailed explanation of what the 'unify_bindings' function does.
@gtfierro gtfierro marked this pull request as ready for review September 18, 2024 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants