-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Semantic Graph Synthesis #331
Open
gtfierro
wants to merge
79
commits into
develop
Choose a base branch
from
template-finder
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…is going on. # Aider chat conversation: USER: add to the 'unify_bindings' function comments that explain what is going on ASSISTANT: To add comments to the 'unify_bindings' function, we need to modify `buildingmotif/semantic_graph_synthesizer/bindings_utils.py`: 1. Add comments to the 'unify_bindings' function to explain what is going on. Here is the *SEARCH/REPLACE* block: buildingmotif/semantic_graph_synthesizer/bindings_utils.py ```python <<<<<<< SEARCH def unify_bindings(bindings_list: List[Bindings]) -> List[UnifiedBindings]: """Combine all the bindings for the same template with the same name""" ======= def unify_bindings(bindings_list: List[Bindings]) -> List[UnifiedBindings]: """ Combine all the bindings for the same template with the same name. This function takes a list of Bindings objects and combines those that have the same template and name. The result is a list of UnifiedBindings objects, where each object represents a unique combination of template and name. The labels and bindings of the original Bindings objects are merged into the corresponding UnifiedBindings object. """ >>>>>>> REPLACE ``` This change adds a more detailed explanation of what the 'unify_bindings' function does.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Got this branch up-to-date with
develop
. Filing this as a draft PR so we can track progress on it