Fix application exploration #287
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
gtfierro
commented
Oct 24, 2023
gtfierro
commented
- loop through the actual URIs, not the query result tuple
- make the query a little more flexible in finding targets
TShapinsky
reviewed
Oct 25, 2023
| @@ -54,7 +54,9 @@ def get_model_graph(models_id: int) -> Graph: | |||
| except NoResultFound: | |||
| return {"message": f"No model with id {models_id}"}, status.HTTP_404_NOT_FOUND | |||
|
|
|||
| return model.graph.serialize(format="ttl"), status.HTTP_200_OK | |||
| g = Graph() + model.graph | |||
There was a problem hiding this comment.
There's also a copy_graph function in utils.py however, looking at the implementation it seems like it might be slower than this. @gtfierro what do you think?
TShapinsky
reviewed
Oct 25, 2023
| WHERE {{ | ||
| ?target a {target_class} | ||
|
|
||
| }} | ||
| }} | ||
| """ | ||
| ) | ||
| targets = model_graph.query( |
There was a problem hiding this comment.
This is a mistake I made when originally writing this method, but I think we can move target resolution outside the for loop to improve performance.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.