Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fuel cost time series parameters methods #1164

Draft
wants to merge 34 commits into
base: jd/add_thermal_time_series
Choose a base branch
from

Conversation

rodrigomha
Copy link
Contributor

No description provided.

_add_time_series_parameters!(container, param, devices, model)
ts_type = get_default_time_series_type(container)
if !(ts_type <: Union{PSY.AbstractDeterministic, PSY.StaticTimeSeries})
error("add_parameters! for TimeSeriesParameter is not compatible with $ts_type")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
error("add_parameters! for TimeSeriesParameter is not compatible with $ts_type")
error("add_parameters! for ObjectiveFunctionParameter is not compatible with $ts_type")

Copy link
Contributor

github-actions bot commented Oct 17, 2024

Performance Results

Version Precompile Time
Main 3.775174872
This Branch 3.788634235
Version Build Time
Main-Build Time Precompile 62.164251408
Main-Build Time Postcompile 0.970753087
This Branch-Build Time Precompile 62.668973906
This Branch-Build Time Postcompile 1.174789145
Version Build Time
Main-Solve Time Precompile 874.221773026
Main-Solve Time Postcompile 841.014083506
This Branch-Solve Time Precompile 441.585425325
This Branch-Solve Time Postcompile 401.524321625

Copy link

codecov bot commented Oct 17, 2024

Codecov Report

Attention: Patch coverage is 54.59770% with 79 lines in your changes missing coverage. Please review.

Project coverage is 76.18%. Comparing base (fc6fc96) to head (d20061c).

Files with missing lines Patch % Lines
src/parameters/update_cost_parameters.jl 0.00% 38 Missing ⚠️
...models/devices/common/objective_function/common.jl 11.76% 15 Missing ⚠️
src/parameters/add_parameters.jl 40.00% 15 Missing ⚠️
src/core/optimization_container.jl 0.00% 3 Missing ⚠️
...ices/common/objective_function/piecewise_linear.jl 86.36% 3 Missing ⚠️
.../devices/common/objective_function/linear_curve.jl 0.00% 2 Missing ⚠️
src/core/expressions.jl 50.00% 1 Missing ⚠️
...vices/common/objective_function/quadratic_curve.jl 0.00% 1 Missing ⚠️
src/devices_models/devices/thermal_generation.jl 50.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                      Coverage Diff                       @@
##           jd/add_thermal_time_series    #1164      +/-   ##
==============================================================
- Coverage                       76.30%   76.18%   -0.13%     
==============================================================
  Files                             121      121              
  Lines                           13149    13301     +152     
==============================================================
+ Hits                            10034    10133      +99     
- Misses                           3115     3168      +53     
Flag Coverage Δ
unittests 76.18% <54.59%> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/PowerSimulations.jl 100.00% <ø> (ø)
src/core/device_model.jl 82.35% <ø> (ø)
src/core/parameters.jl 66.03% <100.00%> (+0.32%) ⬆️
...vice_constructors/thermalgeneration_constructor.jl 94.79% <100.00%> (+0.29%) ⬆️
...devices_models/devices/common/add_to_expression.jl 74.65% <100.00%> (+1.44%) ⬆️
src/core/expressions.jl 53.33% <50.00%> (-0.52%) ⬇️
...vices/common/objective_function/quadratic_curve.jl 79.03% <0.00%> (+1.25%) ⬆️
src/devices_models/devices/thermal_generation.jl 84.56% <50.00%> (-0.16%) ⬇️
.../devices/common/objective_function/linear_curve.jl 81.39% <0.00%> (ø)
src/core/optimization_container.jl 75.72% <0.00%> (-0.21%) ⬇️
... and 4 more

... and 1 file with indirect coverage changes

@jd-lara jd-lara linked an issue Oct 17, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement TimeSeries methods for FuelPrice
2 participants