GitHub CI Pipeline update for debugging forked PR support #3056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TerrenceMcGuinness-NOAA
changed the title
TerrenceMcGuinness-NOAA
requested review from
WalterKolczynski-NOAA and
DavidHuber-NOAA
Comment on lines
+102
to
+103
| repository: ${{ steps.git-branch.outputs.BRANCH }} | ||
| ref: ${{ steps.git-branch.outputs.REPO }} |
There was a problem hiding this comment.
Is this supposed to be
Suggested change
| repository: ${{ steps.git-branch.outputs.BRANCH }} | |
| ref: ${{ steps.git-branch.outputs.REPO }} | |
| repository: ${{ steps.fetch-branch.outputs.BRANCH }} | |
| ref: ${{ steps.fetch-branch.outputs.REPO }} |
KateFriedman-NOAA
added a commit
that referenced
this pull request
Nov 1, 2024
)" This reverts commit 5e867df.
|
@TerrenceMcGuinness-NOAA Could you please respond to my comment above and open a new PR? |
DavidHuber-NOAA
pushed a commit
that referenced
this pull request
Nov 1, 2024
…3057) Reverts #3056 @TerrenceMcGuinness-NOAA will open a new PR for these changes to be reviewed and approved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updating GitHub CI pipeline's bug with passing repo variables for
actions/checkout@v4to support forked PRs.Had to debug directly from develop in authoritative repo because did not not have fork of fork for the development tests.
Type of change