Second reconciliation PR from production/RRFSv1 #881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 tasks
|
@jkbk2004 Ready to review/merge. |
jkbk2004
approved these changes
Nov 8, 2024
DusanJovic-NOAA
approved these changes
Nov 8, 2024
tsga
added a commit
to tsga/fv3atm
that referenced
this pull request
Nov 13, 2024
* develop: Second reconciliation PR from production/RRFSv1 (NOAA-EMC#881) STY: Use capital W and lowercase m for watts per square meter (NOAA-EMC#859)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is analogous to #789 into production/RRFS.v1
Note that although the original PR contained a temporary fix for the
-check allissue for NCO adoption, this temporary fix is no longer needed due to other changes in the CCPP framework and fv3atm that have already been merged. The associated changes to the ccpp-framework and atmos_cubed_sphere are not needed (and are not included in this PR) since we're no longer allocating all variables to zero size. Variables can successfully remain unallocated.This PR does contain the following changes:
There was also some cleanup done to remove variables that are declared in GFS_ and CCPP_typedefs.F90 but are not being used anywhere anymore. In addition, the ACTIVE attribute in the metadata files was double-checked for every conditionally-allocated variable.
Some of the changes to the active attribute required follow-on changes in the CCPP physics: ufs-community/ccpp-physics#228
Issue(s) addressed
None
Testing
This was testing using the full rt.conf on Hera. The
-check allflag was added to the debug mode in the Intel.cmake file for testing and no runtime errors were noted in the RTsDependencies
waiting on ufs-community/ccpp-physics#228
Requirements before merging