Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A merra2 interpolation bug found by running RRFS #750

Merged
merged 3 commits into from
Jan 16, 2024

Conversation

AnningCheng-NOAA
Copy link
Contributor

@AnningCheng-NOAA AnningCheng-NOAA commented Jan 9, 2024

Description

(Instructions: this, and all subsequent sections of text should be removed and filled in as appropriate.)
Provide a detailed description of what this PR does.
What bug does it fix, or what feature does it add?
A merra2 interpolation bug
Is a change of answers expected from this PR?
Yes. Changes are expected in all conus_13km related RTs when one inner model level is equal to one of the MERRA2 pressure level.

Issue(s) addressed

#152
Link the issues to be closed with this PR, whether in this repository, or in another repository.
(Remember, issues should always be created before starting work on a PR branch!)

  • fixes #<152>
  • fixes noaa-emc/fv3atm/issues/<issue_number>

Testing

How were these changes tested?
RTS in hera
What compilers / HPCs was it tested with?
hera intel
Are the changes covered by regression tests? (If not, why? Do new tests need to be added?)
yes
Have the ufs-weather-model regression test been run? On what platform?
full RTs in hera

  • Will the code updates change regression test baseline? If yes, why? Please show the baseline directory below.
    Yes. New baselines are needed for all conus_13km related tests. Namely:
    conus13km_2threads conus13km_debug conus13km_debug_decomp conus13km_decomp conus13km_restart
    conus13km_control conus13km_debug_2threads conus13km_debug_qr conus13km_radar_tten_debug conus13km_restart_mismatch
  • Please commit the regression test log files in your ufs-weather-model branch
    yes. Committed in A MERRA2 aerosol interpolation bug was found by RRFS  ufs-community/ufs-weather-model#2082

Dependencies

If testing this branch requires non-default branches in other repositories, list them.
Those branches should have matching names (ideally)

Do PRs in upstream repositories need to be merged first?
If so add the "waiting for other repos" label and list the upstream PRs

@junwang-noaa
Copy link
Collaborator

@AnningCheng-NOAA there is a CI update in FV3ATM, would you please sync your fv3atm branch? Thanks

@AnningCheng-NOAA
Copy link
Contributor Author

AnningCheng-NOAA commented Jan 12, 2024 via email

@grantfirl
Copy link
Collaborator

@AnningCheng-NOAA ufs-community/ccpp-physics#153 was merged. You're ready to revert the change to .gitmodules and git add the latest commit of the ufs/dev branch of ccpp-physics: ufs-community/ccpp-physics@a492add

@jkbk2004
Copy link
Collaborator

@AnningCheng-NOAA physics pr was merge. Can you update hash and revert change in gitmodules ? Correct hash is ufs-community/ccpp-physics@a492add

@jkbk2004 jkbk2004 merged commit 095a1d5 into NOAA-EMC:develop Jan 16, 2024
2 checks passed
@AnningCheng-NOAA
Copy link
Contributor Author

Thank you all for the effort!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants