A merra2 interpolation bug found by running RRFS #750
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
(Instructions: this, and all subsequent sections of text should be removed and filled in as appropriate.)
Provide a detailed description of what this PR does.
What bug does it fix, or what feature does it add?
A merra2 interpolation bug
Is a change of answers expected from this PR?
Yes. Changes are expected in all conus_13km related RTs when one inner model level is equal to one of the MERRA2 pressure level.
Issue(s) addressed
#152
Link the issues to be closed with this PR, whether in this repository, or in another repository.
(Remember, issues should always be created before starting work on a PR branch!)
Testing
How were these changes tested?
RTS in hera
What compilers / HPCs was it tested with?
hera intel
Are the changes covered by regression tests? (If not, why? Do new tests need to be added?)
yes
Have the ufs-weather-model regression test been run? On what platform?
full RTs in hera
Yes. New baselines are needed for all conus_13km related tests. Namely:
conus13km_2threads conus13km_debug conus13km_debug_decomp conus13km_decomp conus13km_restart
conus13km_control conus13km_debug_2threads conus13km_debug_qr conus13km_radar_tten_debug conus13km_restart_mismatch
yes. Committed in A MERRA2 aerosol interpolation bug was found by RRFS ufs-community/ufs-weather-model#2082
Dependencies
If testing this branch requires non-default branches in other repositories, list them.
Those branches should have matching names (ideally)
Do PRs in upstream repositories need to be merged first?
If so add the "waiting for other repos" label and list the upstream PRs