-
Notifications
You must be signed in to change notification settings - Fork 543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolve division by 0 when meshcap is run with WW3-CICE coupling; Add timers and overwrite capability for mod_def timesteps to meshcap #1163
Conversation
* mod_def with slow timesteps overwritten verifies against run using mod_def containing the fast timesteps * mod_def with slow timesteps overwritten reproduces on restart
* unlike CICE, there is no CESM specific shr code used in WW3
Thank you @DeniseWorthen. I'll put the tests in. |
@JessicaMeixner-NOAA Can you review please? I think Matt is out. We need sub-component review completed for UWM testing. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DeniseWorthen - You are correct, Matt is out. I've approved.
Hi, @JessicaMeixner-NOAA @DeniseWorthen testing is complete on UFS-WM PR #2085 . Can you please merge this sub-PR? |
4ffc47e
into
NOAA-EMC:dev/ufs-weather-model
@zach1221 @DeniseWorthen Merged |
… fix2/sync-dev/unified * origin/mods/dev/ufs-weather-model: matrix_cmake_ncep: update modules for spack-stack prevent division by 0 in appendtail and add timers to meshcap (NOAA-EMC#1163)
Pull Request Summary
Resolve potential division by zero found when coupling WW3 with CICE.
Adds run timers to the meshcap.
Description
Issue(s) addressed
Adds generation of a timer log in the meshcap, which will report, for example, the time spent in
modelAdvance
as well as the time spent before starting the next Advance. The capability is added using a wrapper mod (mimicking the CICE wrapper mod) so that no additional ifdefs are required in the cap. The output generated inlog.ww3.timer
isAlso adds capability to over-write timesteps from the mod_def file with other values. See associated UWM ufs-community/ufs-weather-model#2086 for description of how this works.
Commit Message
prevent division by 0 in appendtail and add timers to meshcap
Check list
Testing
Regression tests in UWM were run. Logs are posted in associated UWM PR #2085 ufs-community/ufs-weather-model#2085