Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WW3 2dm File Format #1148

Draft
wants to merge 27 commits into
base: develop
Choose a base branch
from
Draft

WW3 2dm File Format #1148

wants to merge 27 commits into from

Conversation

aronroland
Copy link
Collaborator

Pull Request Summary

Add alternative File Format for the use of WW3 by ERDC. This is the native SMS format called *.2dm.

Description

Beside the new format, active boundary and Neuman type boundary conditions can be prescribed in the meshbnd.2dm file. The file name is yet default.

Please also include the following information:

  • Add any suggestions for a reviewer
    none
  • Mention any labels that should be added:
    new feature
  • Are answer changes expected from this PR?
    None, but a new regression test was designed. Needs to be discussed.
    -->

Issue(s) addressed

none

Commit Message

Add 2dm file format for unstructured grids.

Check list

Testing

  • How were these changes tested?
    In a new regtest based on tp2.6.
  • Are the changes covered by regression tests? (If not, why? Do new tests need to be added?)
    Yes, see above.
  • Have the matrix regression tests been run (if yes, please note HPC and compiler)?
    No
  • Please indicate the expected changes in the regression test output, (Note the list of known non-identical tests.)
    None expected.
  • Please provide the summary output of matrix.comp (matrix.Diff.txt, matrixCompFull.txt and matrixCompSummary.txt):
    Will be done ...

@JessicaMeixner-NOAA
Copy link
Collaborator

@aronroland since this is from the ERDC fork, we are expecting regression test information before we start review and testing on this PR. I did notice that you have deleted the ufs1.2 regression test. Was this intentional? I don't see any mention of it in the PR description.

@aronroland
Copy link
Collaborator Author

aronroland commented Dec 19, 2023 via email

@JessicaMeixner-NOAA
Copy link
Collaborator

@aronroland no worries, we'll just want to make sure that regression test is added back before we proceed with this PR.

@JessicaMeixner-NOAA
Copy link
Collaborator

Converting to draft. Please mark as ready for review after testing information is available.

@JessicaMeixner-NOAA JessicaMeixner-NOAA marked this pull request as draft January 16, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants