Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add modulefiles for Hercules #760

Merged
merged 3 commits into from
Aug 10, 2023
Merged

Add modulefiles for Hercules #760

merged 3 commits into from
Aug 10, 2023

Conversation

WenMeng-NOAA
Copy link
Collaborator

Add a new modulefiles to port UPP on Hercules.

@WenMeng-NOAA WenMeng-NOAA linked an issue Aug 9, 2023 that may be closed by this pull request
Add modulefiles for Hercules #753
Closed
@WenMeng-NOAA WenMeng-NOAA added enhancement New feature or request No Baseline Change No baseline of the UPP regression tests are made. Ready for Review This PR is ready for code review. labels Aug 10, 2023
@WenMeng-NOAA
Copy link
Collaborator Author

@FernandoAndrade-NOAA You may start the RT on Hera. There will be no changed results with this PR.

@FernandoAndrade-NOAA
Copy link
Collaborator

@FernandoAndrade-NOAA You may start the RT on Hera. There will be no changed results with this PR.

I'm not sure this PR is ready. A hercules.lua file should be included in addition to the detect_machine changes right?

@WenMeng-NOAA
Copy link
Collaborator Author

@FernandoAndrade-NOAA You may start the RT on Hera. There will be no changed results with this PR.

I'm not sure this PR is ready. A hercules.lua file should be included in addition to the detect_machine changes right?

@FernandoAndrade-NOAA Thanks for catching this. Forgot to commit it to github. Please try it.

@FernandoAndrade-NOAA
Copy link
Collaborator

UPP RTs have finished on Hera with no changes to results.

@FernandoAndrade-NOAA
Copy link
Collaborator

This would be closing out #719 as well?

@WenMeng-NOAA
Copy link
Collaborator Author

This would be closing out #719 as well?

yes.

@WenMeng-NOAA
Copy link
Collaborator Author

The UPP standalone test with hafs model files was successfully completed on Hercules.

@WenMeng-NOAA
Copy link
Collaborator Author

This PR is ready for merging.

@WenMeng-NOAA WenMeng-NOAA merged commit 520cc23 into NOAA-EMC:develop Aug 10, 2023
4 checks passed
@WenMeng-NOAA WenMeng-NOAA mentioned this pull request Aug 10, 2023
Closed
@MichaelLueken MichaelLueken mentioned this pull request Sep 21, 2023
Open
@DavidHuber-NOAA DavidHuber-NOAA mentioned this pull request Dec 6, 2023
Closed
17 tasks
@WenMeng-NOAA WenMeng-NOAA deleted the post_hercules branch February 23, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FernandoAndrade-NOAA FernandoAndrade-NOAA FernandoAndrade-NOAA approved these changes

@BijuThomas-NOAA BijuThomas-NOAA BijuThomas-NOAA approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request No Baseline Change No baseline of the UPP regression tests are made. Ready for Review This PR is ready for code review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add modulefiles for Hercules
3 participants
@WenMeng-NOAA @FernandoAndrade-NOAA @BijuThomas-NOAA