Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch to cesm-style field names in MOM6 cap #120

Merged
merged 1 commit into from
Oct 6, 2023

Conversation

DeniseWorthen
Copy link
Collaborator

@DeniseWorthen DeniseWorthen commented Sep 15, 2023

  • modify field names to use CESM-style field names. Field names were aligned with those in https://github.com/ESCOMP/CMEPS/blob/main/mediator/fd_cesm.yaml
  • removes cesm_coupled restriction on enthalpy fields (fields are added to ufs field dictionary)
  • two fields remain unresolved, sea_level and mass_overlying_ice, currently unused

* two fields remain unresolved, sea_level and mass_overlying_ice
@DeniseWorthen
Copy link
Collaborator Author

@jiandewang I'm not sure of the status of this on the NCAR side. I think you were waiting on some in-progress work before they were able to test? We're looking to try to commit this early next week so we can move forward w/ sending the NCEP note out to the authors for review.

@jiandewang
Copy link
Collaborator

@jiandewang I'm not sure of the status of this on the NCAR side. I think you were waiting on some in-progress work before they were able to test? We're looking to try to commit this early next week so we can move forward w/ sending the NCEP note out to the authors for review.

@DeniseWorthen let me coordinate with Gustavo, asking him to have a test on this PR. He is struggle with current NCAR PR which has trouble on our wcoss2 machine and it's not a simple task.

Copy link
Collaborator

@jiandewang jiandewang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

got greenlight from NCAR, good to go

@DeniseWorthen
Copy link
Collaborator Author

@jiandewang We're ready to merge this PR. Thanks for your help in getting it tested.

@jiandewang jiandewang merged commit 02d4dc4 into NOAA-EMC:dev/emc Oct 6, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants