Gnssrwnd1.0 #747
Merged
Gnssrwnd1.0 #747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added the GNSS-R ocean wind speed assimilation to GSI. The following source code routines have been added or changed: 1. gsi_gnssrspdOper.F90 2. intgnssrspd.f90 3. m_gnssrspdNode.F90 4. read_gnssrspd.f90 5. setupgnssrspd.f90 6. 55 stpgnssrspd.f90 7. 23 gsimain.f90 8. gsi_obOperTypeManager.F90 9. intjo.f90 10. rhs.F90 11. obsmod.F90 12. setuprhsall.f90 13. statsconv.f90 14. convinfo.f90 15. read_obs.F90
Merge remote-tracking branch 'upstream/develop' into develop Conflicts: src/gsi/intjo.f90 src/gsi/obsmod.F90 src/gsi/setuprhsall.f90 src/gsi/statsconv.f90
Removed repeated block and merge conflicts
|
Great!! This is exactly what we need. |
|
Thank you @emilyhcliu |
emilyhcliu
reviewed
May 14, 2024
|
Thank you @KariA-Spire for recent updates. Please update |
|
WCOSS2 (Dogwood) ctest |
|
@RussTreadon-NOAA, I want to give you a big THANK YOU for the thorough review. I believe I have addressed all of your latest comments, but please let me know if you have any additional concerns and the next steps. Also, thank you very much @emilyhcliu, @xincjin-NOAA, and @ilianagenkova for your reviews and comments. Best regards! |
|
@KariA-Spire Could you send me an example BUFR file of the data so that I can make a test run for all these codes? In addition, I am wondering if you could send me the source code for NCEP-flavor BUFR encoders? I am suppose to assimilate the GNSS_R wind speed in GSI, the source code will be very helpful. Thanks! Xin |
|
@xincjin-NOAA, could you please send me an email with your request so I can forward it to the appropriate individuals at Spire. Karina . Apodaca @ spire . com |
Thank you so much! I have sent an email request to the email above. Xin |
|
Thank you @xincjin-NOAA for your comment and request. I'm glad to hear that you will test the code with data. None of our existing GSI regression tests exercise the new code. If it does not take too long to obtain data and run run GNSS_R wind data through the code, we will keep this PR open until tests confirm that the code works on WCOSS2 and/or NOAA RDHPCS machines as expected. |
|
Hercules ctest |
|
@KariA-Spire , where from did you read the GNSS-R data you assimilated? In NCEP at the moment we have gpsro and gpsipw, but as far as I know they don't contain wind info. |
|
GSI It's possible that not all the above variables are unused. We need to check the above variables in the indicate routines to see if they are truly not used. Those that are not used need to be removed. |
|
@RussTreadon-NOAA, I'll take a look at the list of used variables. From a quick glance there are several that should be used. |
|
Remove most of the unused variables from gnssrwnd source code files. The following variables are flagged as not being used These variables are found in existing |
|
WCOSS2 ctests |
|
@KariA-Spire , @emilyhcliu , and @xincjin-NOAA : I would like to get this set of changes into |
|
@RussTreadon-NOAA I am fine with the approach. Thanks, |
|
I'm fine with that approach too!
…On Mon, Jul 8, 2024 at 12:36 PM xincjin-NOAA ***@***.***> wrote:
@RussTreadon-NOAA <https://github.com/RussTreadon-NOAA> I am fine with
the approach. Thanks,
—
Reply to this email directly, view it on GitHub
<#747 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AOC4YXW4HSG6ZECFTO4U3GTZLK5YRAVCNFSM6AAAAABHUSWSYWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMJUGY2DKMBQGA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Thank you @ilianagenkova and @xincjin-NOAA for your replies. Although @KariA-Spire and @emilyhcliu have not yet replied, I will move forward and work with the GSI review committee to merge this PR into |
|
Thank you @RussTreadon-NOAA, @ilianagenkova, @xincjin-NOAA , @emilyhcliu! |
DavidHuber-NOAA
added a commit
to DavidHuber-NOAA/GSI
that referenced
this pull request
Sep 6, 2024
* origin/develop: Move to contrib spack-stack on Jet (NOAA-EMC#787) a quick workaround for increasing the mpi task numbers on orion for ctest :: rrfs_3denvar_rdasens (NOAA-EMC#788) Recover the capability of handling model fields from operation gfs.v16.3 (NOAA-EMC#785) fix a bug in deter_sfc_gmi (NOAA-EMC#781) add safeguard to thompson_reff (NOAA-EMC#779) Fix incorrect usage of real(i_kind) in mg_input.f90 (NOAA-EMC#760) Transition to Thompson Microphysics for Microwave All-sky Assimilation (NOAA-EMC#743) Format changes for EUMETSAT metop-sg and CADS debug fix (NOAA-EMC#773) Update global_4denvar and global_enkf ctests to reflect GFS v17 (NOAA-EMC#774) fix for cris-fsr memory corruption (NOAA-EMC#767) Gnssrwnd1.0 (NOAA-EMC#747)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Type of Change
New GNSS-R ocean wind speed observation operator and assimilation capability in GSI
This source code can directly assimilate GNSS-R L2 ocean wind speed retrievals from commercial Spire Global, Inc. and NASA/CYGNSS satellites
Resolves #628
New feature (non-breaking change which adds functionality)
How Has This Been Tested?
Checklist
My code follows the style guidelines of this project
I have performed a self-review of my code
I have commented my code, particularly in hard-to-understand areas
Any dependent changes have been merged and published
File Changes
M gsimain.f90
M gsi_obOperTypeManager.F90
M intjo.f90
M _rhs.F90
M obsmod.F90
M setuprhsall.f90
M statsconv.f90
M convinfo.f90
M read_obs.F90
N gsi_gnssrspdOper.F90
N intgnssrspd.f90
N m_gnssrspdNode.F90
N read_gnssrspd.f90
N setupgnssrspd.f90
N stpgnssrspd.f90
Link to the forked branch:https://github.com/KariA-Spire/GSI/tree/gnssrwnd1.0
Note: Upon request, we can facilitate source code for NCEP-flavor BUFR encoders, BUFR files, and JEDI/IODA converters. We can also guide users on observation error and bias correction treatment on an "as-time-permits" basis.
Spire Global, Inc. developed this assimilation capability under partial funding from the NASA CYGNSS ROSES-2020 Grant number 80NSSC21K1120.