selection_sort.py: Add SelectionSort Algo #447

de-sh · 2018-10-25T10:56:15Z

This adds SelectionSort Algorithm, which sorts
the element in O(n^2) time complexity. This PR
has the Python implementation of this algo.

Fixes #446

By submitting this pull request I confirm I've read and complied with the
below declarations.

I have read the Contribution guidelines and I am confident that my PR reflects them.
I have followed the commit guidelines for this project.
My code follows the standard code structure.
This pull request has a descriptive title. For example, {Tag}: Add {Algorithm/DS name} [{Language}], not Update README.md or Added new code.
This pull request will be closed if I fail to update it even once in a continuous time span of 7 days.
This pull request shall only be reviewed and merged once all the checks passes. No maintainer or supporter shall be obliged to review it before this condition is met.
I have mentioned the issue number correctly (with hyperlink) in this pull request description.

Made changes including denoting completion of selection sort implementation in Python as well as standardization of Markdown

sangamcse · 2018-10-25T11:00:38Z

Comment on cc39a18, file selection_sort/python/selection_sort.py, line 8.

The code does not comply to PEP8.

Origin: PEP8Bear, Section: all.autopep8.

The issue can be fixed by applying the following patch:

--- a/tmp/tmp8sjn3jnu/selection_sort/python/selection_sort.py
+++ b/tmp/tmp8sjn3jnu/selection_sort/python/selection_sort.py
@@ -6,6 +6,7 @@
             if Arr[j] < Arr[low]:
                 low = j
         Arr[i], Arr[low] = Arr[low], Arr[i]
+
 
 # Given array
 Arr = [4, 3, 42, 82, 5, 2, 33]

sangamcse · 2018-10-25T11:00:39Z

Comment on cc39a18, file selection_sort/python/selection_sort.py, line 4.

E703 statement ends with a semicolon

Origin: PycodestyleBear (E703), Section: all.autopep8.

sangamcse · 2018-10-25T11:00:39Z

Comment on cc39a18, file selection_sort/python/selection_sort.py, line 11.

E305 expected 2 blank lines after class or function definition, found 1

Origin: PycodestyleBear (E305), Section: all.autopep8.

sangamcse · 2018-10-25T11:07:28Z

Comment on 93edc39, file selection_sort/python/selection_sort.py, line 4.

The code does not comply to PEP8.

Origin: PEP8Bear, Section: all.autopep8.

The issue can be fixed by applying the following patch:

--- a/tmp/tmpgvi3mzjv/selection_sort/python/selection_sort.py
+++ b/tmp/tmpgvi3mzjv/selection_sort/python/selection_sort.py
@@ -1,7 +1,7 @@
 # Function to do selection sort of given array(Arr)
 def selection_sort(Arr):
     for i in range(len(Arr)):
-        low = i;
+        low = i
         for j in range(i+1, len(Arr)):
             if Arr[j] < Arr[low]:
                 low = j

sangamcse · 2018-10-25T11:07:29Z

Comment on 93edc39, file selection_sort/python/selection_sort.py, line 8.

The code does not comply to PEP8.

Origin: PEP8Bear, Section: all.autopep8.

The issue can be fixed by applying the following patch:

--- a/tmp/tmpgvi3mzjv/selection_sort/python/selection_sort.py
+++ b/tmp/tmpgvi3mzjv/selection_sort/python/selection_sort.py
@@ -6,6 +6,7 @@
             if Arr[j] < Arr[low]:
                 low = j
         Arr[i], Arr[low] = Arr[low], Arr[i]
+
 
 # Given array
 Arr = [4, 3, 42, 82, 5, 2, 33]

sangamcse · 2018-10-25T11:07:30Z

Comment on 93edc39, file selection_sort/python/selection_sort.py, line 4.

E703 statement ends with a semicolon

Origin: PycodestyleBear (E703), Section: all.autopep8.

sangamcse · 2018-10-25T11:07:31Z

Comment on 93edc39, file selection_sort/python/selection_sort.py, line 11.

E305 expected 2 blank lines after class or function definition, found 1

Origin: PycodestyleBear (E305), Section: all.autopep8.

sangamcse · 2018-10-25T11:07:53Z

Comment on f00d9de, file selection_sort/python/selection_sort.py, line 4.

The code does not comply to PEP8.

Origin: PEP8Bear, Section: all.autopep8.

The issue can be fixed by applying the following patch:

--- a/tmp/tmpghornuhk/selection_sort/python/selection_sort.py
+++ b/tmp/tmpghornuhk/selection_sort/python/selection_sort.py
@@ -1,7 +1,7 @@
 # Function to do selection sort of given array(Arr)
 def selection_sort(Arr):
     for i in range(len(Arr)):
-        low = i;
+        low = i
         for j in range(i+1, len(Arr)):
             if Arr[j] < Arr[low]:
                 low = j

sangamcse · 2018-10-25T11:07:54Z

Comment on f00d9de, file selection_sort/python/selection_sort.py, line 8.

The code does not comply to PEP8.

Origin: PEP8Bear, Section: all.autopep8.

The issue can be fixed by applying the following patch:

--- a/tmp/tmpghornuhk/selection_sort/python/selection_sort.py
+++ b/tmp/tmpghornuhk/selection_sort/python/selection_sort.py
@@ -6,6 +6,7 @@
             if Arr[j] < Arr[low]:
                 low = j
         Arr[i], Arr[low] = Arr[low], Arr[i]
+
 
 # Given array
 Arr = [4, 3, 42, 82, 5, 2, 33]

sangamcse · 2018-10-25T11:07:55Z

Comment on f00d9de, file selection_sort/python/selection_sort.py, line 4.

E703 statement ends with a semicolon

Origin: PycodestyleBear (E703), Section: all.autopep8.

sangamcse · 2018-10-25T11:07:56Z

Comment on f00d9de, file selection_sort/python/selection_sort.py, line 11.

E305 expected 2 blank lines after class or function definition, found 1

Origin: PycodestyleBear (E305), Section: all.autopep8.

sangamcse · 2018-10-25T11:09:39Z

Comment on 1fbb1f5, file selection_sort/python/selection_sort.py, line 4.

The code does not comply to PEP8.

Origin: PEP8Bear, Section: all.autopep8.

The issue can be fixed by applying the following patch:

--- a/tmp/tmp3lch9w2z/selection_sort/python/selection_sort.py
+++ b/tmp/tmp3lch9w2z/selection_sort/python/selection_sort.py
@@ -1,7 +1,7 @@
 # Function to do selection sort of given array(Arr)
 def selection_sort(Arr):
     for i in range(len(Arr)):
-        low = i;
+        low = i
         for j in range(i+1, len(Arr)):
             if Arr[j] < Arr[low]:
                 low = j

sangamcse · 2018-10-25T11:09:39Z

Comment on 1fbb1f5, file selection_sort/python/selection_sort.py, line 8.

The code does not comply to PEP8.

Origin: PEP8Bear, Section: all.autopep8.

The issue can be fixed by applying the following patch:

--- a/tmp/tmp3lch9w2z/selection_sort/python/selection_sort.py
+++ b/tmp/tmp3lch9w2z/selection_sort/python/selection_sort.py
@@ -6,6 +6,7 @@
             if Arr[j] < Arr[low]:
                 low = j
         Arr[i], Arr[low] = Arr[low], Arr[i]
+
 
 # Given array
 Arr = [4, 3, 42, 82, 5, 2, 33]

sangamcse · 2018-10-25T11:09:40Z

Comment on 1fbb1f5, file selection_sort/python/selection_sort.py, line 4.

E703 statement ends with a semicolon

Origin: PycodestyleBear (E703), Section: all.autopep8.

sangamcse · 2018-10-25T11:09:41Z

Comment on 1fbb1f5, file selection_sort/python/selection_sort.py, line 11.

E305 expected 2 blank lines after class or function definition, found 1

Origin: PycodestyleBear (E305), Section: all.autopep8.

sangamcse

Write good commit message which is given in the contributing guidelines

README.md

selection_sort/python/selection_sort.py

123vivekr

Please fix your commit message. Do take a look at commit guidelines.
Do squash your commits (Try rebasing ;))

de-sh

I believe all these changes are valid and agree to the application of the same to my code. I am still not an expert at GitHub and so I've made all changes as a separate branch for which I am ready to send a PR

Implementing best practices in writing markdown files I have complied with specification set by [markdownlint](https://github.com/DavidAnson/markdownlint/blob/v0.11.0/doc/Rules.md)

sangamcse · 2018-10-26T20:02:47Z

Comment on 98443df, file selection_sort/python/selection_sort.py, line 4.

The code does not comply to PEP8.

Origin: PEP8Bear, Section: all.autopep8.

The issue can be fixed by applying the following patch:

--- a/tmp/tmp52dhoqv4/selection_sort/python/selection_sort.py
+++ b/tmp/tmp52dhoqv4/selection_sort/python/selection_sort.py
@@ -1,7 +1,7 @@
 # Function to do selection sort of given array(Arr)
 def selection_sort(Arr):
     for i in range(len(Arr)):
-        low = i;
+        low = i
         for j in range(i+1, len(Arr)):
             if Arr[j] < Arr[low]:
                 low = j

sangamcse · 2018-10-26T20:02:48Z

Comment on 98443df, file selection_sort/python/selection_sort.py, line 8.

The code does not comply to PEP8.

Origin: PEP8Bear, Section: all.autopep8.

The issue can be fixed by applying the following patch:

--- a/tmp/tmp52dhoqv4/selection_sort/python/selection_sort.py
+++ b/tmp/tmp52dhoqv4/selection_sort/python/selection_sort.py
@@ -6,6 +6,7 @@
             if Arr[j] < Arr[low]:
                 low = j
         Arr[i], Arr[low] = Arr[low], Arr[i]
+
 
 # Given array
 Arr = [4, 3, 42, 82, 5, 2, 33]

sangamcse · 2018-10-26T20:02:49Z

Comment on 98443df, file selection_sort/python/selection_sort.py, line 4.

E703 statement ends with a semicolon

Origin: PycodestyleBear (E703), Section: all.autopep8.

sangamcse · 2018-10-26T20:02:50Z

Comment on 98443df, file selection_sort/python/selection_sort.py, line 11.

E305 expected 2 blank lines after class or function definition, found 1

Origin: PycodestyleBear (E305), Section: all.autopep8.

Compliance to PEP8 standards was maintained in the above correction to code.

selection_sort/python/selection_sort.py

sangamcse

Fix the Travis checks as your PR is breaking that. See the comments on your code above; you need to fix those.

sangamcse · 2018-10-26T20:42:50Z

README.md

+| Python          | ```python [filename.py]```                                               |
+| C               | ```gcc [filename.c]```<br>```./a.out  # unix```<br>```a.exe  # windows```|
+| CPP             | ```g++ [filename.cpp]```<br>```./a.out # unix```<br>```a.exe # windows```|
+| Java            | ```javac [filename.java]```<br>```java [filename]```                     |


These changes needs to be ignored as it is being used as HTML tags and then being used for the website https://nitskmos.github.io/Algorithms/.

Is this what you want it to look like?

sangamcse · 2018-10-26T20:43:16Z

README.md

@@ -39,17 +37,15 @@ This repository contains examples of various algorithms written on different pro
 | [Binary Search Tree](https://en.wikipedia.org/wiki/Binary_search_tree)                          |                                       | [:octocat:](binary_search_tree/Cpp)                                       |                                       |                                       |
 | [Fenwick Tree](https://en.wikipedia.org/wiki/Fenwick_tree)                                      |                                       |                                       | [:octocat:](fenwick_tree/java)        | [:octocat:](fenwick_tree/Python)      |

-


Redundant change

sangamcse · 2018-10-26T20:43:31Z

README.md

@@ -24,9 +23,8 @@ This repository contains examples of various algorithms written on different pro
 | [Shell Sort](https://en.wikipedia.org/wiki/Shellsort)                                           | [:octocat:](shell_sort/C)             |                                       |                                       | [:octocat:](shell_sort/Python)        |
 | [Heap Sort](https://en.wikipedia.org/wiki/Heapsort)                                             |                                       |                                       |                                       | [:octocat:](heap_sort/python)        |
 | [Maximum Subarray Problem](https://en.wikipedia.org/wiki/Maximum_subarray_problem)              |                                       |                                       |                                       | [:octocat:](/maximum_subarray/Python)|
-| [Knapsack Problem](https://en.wikipedia.org/wiki/Knapsack_problem)							  |	                                      |                                       |                                       | [:octocat:](knapsack_problem/Python)|
-| [Selecton Sort](https://en.wikipedia.org/wiki/Selection_sort)							          | [:octocat:](selection_sort/C)	                                      |                                       |                                       |                                        |
-


Redundant change

sangamcse · 2018-10-26T20:43:50Z

README.md

-| [Knapsack Problem](https://en.wikipedia.org/wiki/Knapsack_problem)							  |	                                      |                                       |                                       | [:octocat:](knapsack_problem/Python)|
-| [Selecton Sort](https://en.wikipedia.org/wiki/Selection_sort)							          | [:octocat:](selection_sort/C)	                                      |                                       |                                       |                                        |
-
+| [Knapsack Problem](https://en.wikipedia.org/wiki/Knapsack_problem)  |                                      |                                       |                                       | [:octocat:](knapsack_problem/Python)|


Redundant change

sangamcse · 2018-10-26T20:44:05Z

README.md

@@ -6,7 +6,6 @@
 [![GitHub](https://img.shields.io/github/license/mashape/apistatus.svg)](https://github.com/NITSkmOS/Algorithms/blob/master/LICENSE)
 [![OpenHub](https://www.openhub.net/p/NITSkmOS-algo/widgets/project_thin_badge?format=gif)](https://www.openhub.net/p/NITSkmOS-algo?ref=Thin+badge)

-


Redundant change

de-sh and others added 2 commits October 25, 2018 16:10

Implement selection sort in python

8b14887

Rewrite README.md

cc39a18

Made changes including denoting completion of selection sort implementation in Python as well as standardization of Markdown

sangamcse added process/pending_review size/XS difficulty/low hacktoberfest HACKTOBERFEST 2020 lang/Python type/algo lang/C labels Oct 25, 2018

This comment has been minimized.

Sign in to view

Devdutt Shenoi and others added 3 commits October 25, 2018 16:33

Changes to further standardise README.md

93edc39

Update README.md

f00d9de

Completed README to be properly generated

1fbb1f5

sangamcse removed the lang/C label Oct 25, 2018

sangamcse assigned de-sh Oct 25, 2018

sangamcse added process/wip Work in Progress and removed process/pending_review labels Oct 25, 2018

sangamcse requested changes Oct 25, 2018

View reviewed changes

README.md Outdated Show resolved Hide resolved

selection_sort/python/selection_sort.py Outdated Show resolved Hide resolved

selection_sort/python/selection_sort.py Outdated Show resolved Hide resolved

123vivekr reviewed Oct 25, 2018

View reviewed changes

de-sh closed this Oct 26, 2018

de-sh reopened this Oct 26, 2018

de-sh commented Oct 26, 2018

View reviewed changes

README.md: Made compliant with markdownlint

98443df

Implementing best practices in writing markdown files I have complied with specification set by [markdownlint](https://github.com/DavidAnson/markdownlint/blob/v0.11.0/doc/Rules.md)

sangamcse added process/pending_review and removed process/wip Work in Progress labels Oct 26, 2018

selection_sort.py: REWRITE in accordance to PEP8

95252c7

Compliance to PEP8 standards was maintained in the above correction to code.

sangamcse reviewed Oct 26, 2018

View reviewed changes

selection_sort/python/selection_sort.py Show resolved Hide resolved

sangamcse reviewed Oct 26, 2018

View reviewed changes

selection_sort/python/selection_sort.py Show resolved Hide resolved

de-sh changed the title ~~Add selection sort.py~~ selection_sort.py: Add SelectionSort Algo Oct 26, 2018

selection_sort.py: Deleted all trailing space

ee3be2a

sangamcse reviewed Oct 26, 2018

View reviewed changes

selection_sort/python/selection_sort.py Show resolved Hide resolved

sangamcse requested changes Oct 26, 2018

View reviewed changes

sangamcse added process/wip Work in Progress and removed process/pending_review labels Oct 26, 2018

sangamcse mentioned this pull request Oct 27, 2018

Selection sort in Python (fixed #446) #464

Closed

7 tasks

sangamcse closed this Oct 11, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

selection_sort.py: Add SelectionSort Algo #447

selection_sort.py: Add SelectionSort Algo #447

de-sh commented Oct 25, 2018 •

edited

Loading

This comment has been minimized.

sangamcse commented Oct 25, 2018

sangamcse commented Oct 25, 2018

sangamcse commented Oct 25, 2018

sangamcse commented Oct 25, 2018

sangamcse commented Oct 25, 2018

sangamcse commented Oct 25, 2018

sangamcse commented Oct 25, 2018

sangamcse commented Oct 25, 2018

sangamcse commented Oct 25, 2018

sangamcse commented Oct 25, 2018

sangamcse commented Oct 25, 2018

sangamcse commented Oct 25, 2018

sangamcse commented Oct 25, 2018

sangamcse commented Oct 25, 2018

sangamcse commented Oct 25, 2018

sangamcse left a comment

123vivekr left a comment

de-sh left a comment •

edited

Loading

sangamcse commented Oct 26, 2018

sangamcse commented Oct 26, 2018

sangamcse commented Oct 26, 2018

sangamcse commented Oct 26, 2018

sangamcse left a comment

sangamcse Oct 26, 2018

de-sh Oct 30, 2018

sangamcse Oct 26, 2018

sangamcse Oct 26, 2018

sangamcse Oct 26, 2018

sangamcse Oct 26, 2018

		@@ -39,17 +37,15 @@ This repository contains examples of various algorithms written on different pro
		\| [Binary Search Tree](https://en.wikipedia.org/wiki/Binary_search_tree) \| \| [:octocat:](binary_search_tree/Cpp) \| \| \|
		\| [Fenwick Tree](https://en.wikipedia.org/wiki/Fenwick_tree) \| \| \| [:octocat:](fenwick_tree/java) \| [:octocat:](fenwick_tree/Python) \|

		@@ -6,7 +6,6 @@
		[![GitHub](https://img.shields.io/github/license/mashape/apistatus.svg)](https://github.com/NITSkmOS/Algorithms/blob/master/LICENSE)
		[![OpenHub](https://www.openhub.net/p/NITSkmOS-algo/widgets/project_thin_badge?format=gif)](https://www.openhub.net/p/NITSkmOS-algo?ref=Thin+badge)

selection_sort.py: Add SelectionSort Algo #447

selection_sort.py: Add SelectionSort Algo #447

Conversation

de-sh commented Oct 25, 2018 • edited Loading

This comment has been minimized.

sangamcse commented Oct 25, 2018

sangamcse commented Oct 25, 2018

sangamcse commented Oct 25, 2018

sangamcse commented Oct 25, 2018

sangamcse commented Oct 25, 2018

sangamcse commented Oct 25, 2018

sangamcse commented Oct 25, 2018

sangamcse commented Oct 25, 2018

sangamcse commented Oct 25, 2018

sangamcse commented Oct 25, 2018

sangamcse commented Oct 25, 2018

sangamcse commented Oct 25, 2018

sangamcse commented Oct 25, 2018

sangamcse commented Oct 25, 2018

sangamcse commented Oct 25, 2018

sangamcse left a comment

Choose a reason for hiding this comment

123vivekr left a comment

Choose a reason for hiding this comment

de-sh left a comment • edited Loading

Choose a reason for hiding this comment

sangamcse commented Oct 26, 2018

sangamcse commented Oct 26, 2018

sangamcse commented Oct 26, 2018

sangamcse commented Oct 26, 2018

sangamcse left a comment

Choose a reason for hiding this comment

sangamcse Oct 26, 2018

Choose a reason for hiding this comment

de-sh Oct 30, 2018

Choose a reason for hiding this comment

sangamcse Oct 26, 2018

Choose a reason for hiding this comment

sangamcse Oct 26, 2018

Choose a reason for hiding this comment

sangamcse Oct 26, 2018

Choose a reason for hiding this comment

sangamcse Oct 26, 2018

Choose a reason for hiding this comment

de-sh commented Oct 25, 2018 •

edited

Loading

de-sh left a comment •

edited

Loading