Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CCM-6950 journey tidy up #154

Merged
merged 15 commits into from
Nov 4, 2024
Merged

CCM-6950 journey tidy up #154

merged 15 commits into from
Nov 4, 2024

Conversation

bhansell1
Copy link
Contributor

@bhansell1 bhansell1 commented Oct 25, 2024 •
edited
Loading

Description

  • removes unnecessary comments
  • adds typechecking for each channel
  • page.test.tsx files now mock the component they render, which removes the need for using render on the function. The snapshot tests were just duplicates of the snapshot tests the actual component test executed.
  • moved MessageFormatting to their own files
  • updated accessibility tests

Context

Type of changes

  • Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I am familiar with the contributing guidelines
  • I have followed the code style of the project
  • I have added tests to cover my changes
  • I have updated the documentation accordingly
  • This PR is a result of pair or mob programming

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

@bhansell1 bhansell1 requested a review from a team as a code owner October 25, 2024 12:53
bhansell1
bhansell1 commented Oct 25, 2024
View reviewed changes
package.json Outdated Show resolved Hide resolved
@bhansell1 bhansell1 changed the title DRAFT: CCM-6950 journey tidy up CCM-6950 journey tidy up Oct 28, 2024
m-salaudeen
m-salaudeen previously approved these changes Oct 28, 2024
View reviewed changes
mark-r-bjss
mark-r-bjss previously approved these changes Oct 28, 2024
View reviewed changes
alibombaye
alibombaye previously approved these changes Oct 30, 2024
View reviewed changes
mark-r-bjss
mark-r-bjss previously approved these changes Oct 30, 2024
View reviewed changes
@bhansell1 bhansell1 dismissed stale reviews from mark-r-bjss and alibombaye via 2c436f5 October 31, 2024 09:12
alibombaye
alibombaye previously approved these changes Nov 1, 2024
View reviewed changes
mark-r-bjss
mark-r-bjss previously approved these changes Nov 1, 2024
View reviewed changes
@mark-r-bjss mark-r-bjss dismissed stale reviews from alibombaye and themself via 158f023 November 4, 2024 15:05
@mark-r-bjss mark-r-bjss merged commit 27a4d00 into main Nov 4, 2024
26 checks passed
@mark-r-bjss mark-r-bjss deleted the feature/CCM-6950_journey-tidy-up branch November 4, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mark-r-bjss mark-r-bjss mark-r-bjss approved these changes

@chris-elliott-nhsd chris-elliott-nhsd chris-elliott-nhsd approved these changes

@alibombaye alibombaye alibombaye approved these changes

@m-salaudeen m-salaudeen m-salaudeen left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@bhansell1 @timireland @alibombaye @chris-elliott-nhsd @mark-r-bjss @m-salaudeen