Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/ccm 6323 nhsapp message #136

Merged
merged 5 commits into from
Oct 31, 2024
Merged

Feature/ccm 6323 nhsapp message #136

merged 5 commits into from
Oct 31, 2024

Conversation

jazrattanpal
Copy link
Contributor

Description

Context

Type of changes

  • Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I am familiar with the contributing guidelines
  • I have followed the code style of the project
  • I have added tests to cover my changes
  • I have updated the documentation accordingly
  • This PR is a result of pair or mob programming

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

@jazrattanpal jazrattanpal requested review from a team as code owners October 15, 2024 15:24
@jazrattanpal jazrattanpal force-pushed the feature/CCM-6323-nhsapp-message branch from 0a2c96a to 852c478 Compare October 16, 2024 09:39
chris-elliott-nhsd
chris-elliott-nhsd reviewed Oct 17, 2024
View reviewed changes
.gitleaksignore Outdated Show resolved Hide resolved
Kennedy1265
Kennedy1265 previously approved these changes Oct 31, 2024
View reviewed changes
jas and others added 5 commits October 31, 2024 12:27
@sean-corrigan1
CCM-6323: nhsapp create template tests
d337787 
CCM-6323: nhsapp tests updates

CCM-6323: nhsapp tests review comments updates

CCM-6323: nhsapp tests updates

CCM-6323: nhsapp tests updates

CCM-6323: nhsapp tests updates remove wait

CCM-6323: nhsapp tests updates remove wait
@sean-corrigan1
test updates
a6ebd5b
@sean-corrigan1
CCM-6323: address comment and refactor
5fea7dc
@sean-corrigan1
CCM-6323: addressing comments adding assertations
32b56d5
@sean-corrigan1
CCM-6323: fix id after rebase
f1a68e4
@sean-corrigan1 sean-corrigan1 merged commit 2be0de8 into main Oct 31, 2024
25 checks passed
@sean-corrigan1 sean-corrigan1 deleted the feature/CCM-6323-nhsapp-message branch October 31, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sean-corrigan1 sean-corrigan1 sean-corrigan1 left review comments

@chris-elliott-nhsd chris-elliott-nhsd chris-elliott-nhsd approved these changes

@Kennedy1265 Kennedy1265 Kennedy1265 approved these changes

@mark-r-bjss mark-r-bjss Awaiting requested review from mark-r-bjss

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jazrattanpal @Kennedy1265 @chris-elliott-nhsd @mark-r-bjss @sean-corrigan1