Warren/packaging

[warren-davies4]

Changes

Packaging

• Added the pyproject.toml
• Added the poetry lockfile (this doesn't need reviewing)

Folder structure

• Renamed to codonpython (it didn't seem to like the camel case)
• Updated folder structure to match typical package format (/src/packagename, and /tests/)

Updates to deprecated code

Updating the dependencies meant some of the older deprecated code didn't work. Some fixes:

• One-line change to a pandas df method (when passing aggregate function to df.groupyBy().agg(), you used to pass a built in function, e.g. sum, but that has since been deprecated. Now you need to pass the name of the function as a string e.g. "sum")
• Changed use of the deprecated df.append() to the newer pd.concat() in one place
• Changed pandas.util.testing.assert_frame_equal to the newer pandas.testing.assert_frame_equal

Tweak to tests

• Added a path to the file import function tests. This forces them to scan the tests/ folder instead of the whole project directory, since these might indeed have csvs in them and cause the tests to fail. We will later need to add test csv and xlsx files in the tests/ folder, but that can be another ticker, I have made issues for these

Set up

Ignore the readme! :)

If codespaces, do:

pipx install poetry
python -m venv venv
source venv/bin/activate
poetry install

This will install dependecies and the current package.

Then you can do:

pytest tests/

It is published on Test PyPi so you could also do:

pip install -i https://test.pypi.org/simple/ --extra-index-url https://pypi.org/simple codonpython

and then for example:

from codonpython import nhsNumber 

print(nhsNumber.nhsNumberValidator(1231231230))
>>>False