Support Threads.Condition variables in Select. #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note that you need to unlock the condition inside the body of your select, which is super annoying and kind of makes it not-worth-it to support Condition variables. It would probably be better to just have an assertion error if you try to wait on a condition variable... BUT, anyway, this commit fixes the waiting to support condition variables correctly, I'm pretty sure! :)
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that you need to unlock the condition inside the body of your
select, which is sort of annoying and kind of makes it not-worth-it to
support Condition variables.
It would probably be better to just have an assertion error if you try
to wait on a condition variable...
BUT, anyway, this commit fixes the waiting to support condition
variables correctly, I'm pretty sure! :)
Addresses the second problem listed in #2