-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
calculate sapwood cross-sectional area for grass PFT #1268
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix @XiulinGao. I'm going to make some minor formatting adjustments, but otherwise I think this looks good.
Reminder to self:
|
I conducted some initial regression testing of this by manually modifying the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This all seems to be good to me, apologies for the delay.
Final regression testing underway. Note that I'm using ESCOMP/CTSM#2882 to test as it captures commits that revert the temporary workaround to #1254 which this PR fixes. |
Regression testing is complete. The |
Description:
A subroutine, sapwood_area_grass, is added to calculate sapwood cross-sectional area specifically for grass PFT.
This is added to fix issue #1254
Collaborators:
Expectation of Answer Changes:
Answers will change is FATES Hydro is turned on and using sapwood allometry mod 2
Checklist
If this is your first time contributing, please read the CONTRIBUTING document.
All checklist items must be checked to enable merging this pull request:
Contributor
Integrator
Documentation
Test Results:
CTSM (or) E3SM (specify which) test hash-tag:
CTSM (or) E3SM (specify which) baseline hash-tag:
FATES baseline hash-tag:
Test Output: