修復「誤用 null courseMainInfo」的問題 #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntut-xuan
requested review from
Xanonymous-GitHub,
rileychh,
James-Lu-none,
umeow0716 and
ricky9667
James-Lu-none
requested changes
Feb 28, 2024
There was a problem hiding this comment.
Future<List<CourseStudent>> _getCourseStudent() async {
TaskFlow taskFlow = TaskFlow();
final task = IPlusGetStudentListTask(courseId: courseMainInfo.course.id);
taskFlow.addTask(task);
if (await taskFlow.start()) {
List<CourseStudent> students = task.result;
if (students != null) {
return students;
}
}
return <CourseStudent>[];
}
should be
Future<List<CourseStudent>> _getCourseStudent() async {
TaskFlow taskFlow = TaskFlow();
final courseMainInfo = widget.courseInfo.main; //here
final task = IPlusGetStudentListTask(courseId: courseMainInfo.course.id);
taskFlow.addTask(task);
if (await taskFlow.start()) {
List<CourseStudent> students = task.result;
if (students != null) {
return students;
}
}
return <CourseStudent>[];
}
… hotfix/null_courseMainInfo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
在這個 PR 上修復了誤用 global courseMainInfo 的問題，可能導致以下的 exception 不停觸發。
修復成使用
widget的值，見 Files Changed。How to review it?