Qa 2336 automated test removed vestigial properties #1371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ManjunathJayanna
approved these changes
Nov 13, 2024
|
The checks/validations were very fast, not sure if its really validating the removed properties. |
I made some negative scenarios to ensure the check was really happening when I made the test, so it's checking properly! It happens so fast because looking for text is a quick operation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Test:
vpn2, qa-orange
gauge run specs/gdc_data_portal_v2/cohort_builder/custom_filter_removal.spec
gauge run specs/gdc_data_portal_v2/repository/custom_filter_removal.spec