Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix linting errors & warnings and fix JSdocs in DataPackage (DataPackage cleanup, part 1) #2568

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

robyngit
Copy link
Member

Other than fixing linting errors and JSdocs, this PR:

  • Removes unused properties from DataPackage collection: sourcePackages, derivationPackages, relatedModels. These are used in PackageModel, and we should check if those properties and the logic that uses them are required in the DataPackage (since we plan deprecate PackageModel).
  • Converted some underscore methods (e.g. _.each) to ES6 methods (e.g. .forEach), but there are still many to convert.

This is the first step in issue #2567

In MetadataView. Necessary because we removed two unused props from DataPackage.

Issue #2567
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant