Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow iFrames from trusted sources in MarkdownView #2532
base: develop
Are you sure you want to change the base?
Allow iFrames from trusted sources in MarkdownView #2532
Changes from all commits
eb2e381
27bf4c5
4fd47d5
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [eslint] <prefer-arrow-callback> reported by reviewdog 🐶
Unexpected function expression.
metacatui/src/js/models/AppModel.js
Lines 1 to 2920 in 4fd47d5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [eslint] <no-var> reported by reviewdog 🐶
Unexpected var, use let or const instead.
metacatui/src/js/models/AppModel.js
Lines 12 to 2918 in 4fd47d5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should have no text on the "0th" line (after the
/**
).metacatui/src/js/models/AppModel.js
Lines 1752 to 1756 in 4fd47d5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [eslint] <prefer-object-spread> reported by reviewdog 🐶
Use an object spread instead of
Object.assign
eg:{ ...foo }
.metacatui/src/js/themes/arctic/config.js
Lines 6 to 271 in 4fd47d5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [eslint] <spaced-comment> reported by reviewdog 🐶
Expected exception block, space or tab after '//' in comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [eslint] <prefer-object-spread> reported by reviewdog 🐶
Use an object spread instead of
Object.assign
eg:{ ...foo }
.metacatui/src/js/themes/dataone/config.js
Lines 3 to 168 in 4fd47d5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [eslint] <no-dupe-keys> reported by reviewdog 🐶
Duplicate key 'displayDatasetEditButton'.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [eslint] <no-dupe-keys> reported by reviewdog 🐶
Duplicate key 'displayDatasetControls'.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [eslint] <prefer-object-spread> reported by reviewdog 🐶
Use an object spread instead of
Object.assign
eg:{ ...foo }
.metacatui/src/js/themes/knb/config.js
Lines 6 to 101 in 4fd47d5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [eslint] <no-unused-expressions> reported by reviewdog 🐶
Expected an assignment or function call and instead saw an expression.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [eslint] <no-undef> reported by reviewdog 🐶
'regexHtags' is not defined.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [eslint] <prefer-regex-literals> reported by reviewdog 🐶
Use a regular expression literal instead of the 'RegExp' constructor.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [eslint] <no-sequences> reported by reviewdog 🐶
Unexpected use of comma operator.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [eslint] <no-undef> reported by reviewdog 🐶
'regexImages' is not defined.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [eslint] <no-undef> reported by reviewdog 🐶
'required' is not defined.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [eslint] <import/no-dynamic-require> reported by reviewdog 🐶
Calls to require() should use string literals