Skip to content

Commit

Permalink
patch release 3.8.8 fixing "error.knowledge_graph.edge.attribute.valu…
Browse files Browse the repository at this point in the history
…e.empty" test (for numeric zeros)
  • Loading branch information
RichardBruskiewich committed Aug 21, 2023
1 parent 9a6dd25 commit 588e0c5
Show file tree
Hide file tree
Showing 4 changed files with 13 additions and 10 deletions.
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,9 @@

The Reasoner Validator package is evolving along with progress in TRAPI and Biolink Model standards within the NCATS Biomedical Knowledge Translator.

## 3.8.8
- "error.knowledge_graph.edge.attribute.value.empty" should NOT be triggered by numeric zeros either!

## 3.8.7
- Puzzling issue with validation of some qualifier values turned out to be a bug in the Biolink Model 3.5.2, resolved in 3.5.3, so fixed unit tests accordingly. This release doesn't have any core functional changes to the code but users of earlier versions should be aware that validation with Biolink Model releases earlier than 3.5.3 may give puzzling qualifier value validation messages.

Expand Down
4 changes: 2 additions & 2 deletions DEVELOPER_NOTES.md
Original file line number Diff line number Diff line change
Expand Up @@ -24,10 +24,10 @@ For Github-related performance reasons, as of project release v3.8.3, the code c

Steps to properly issue a new project release:

1. Perform any required **codes.yaml** and **versions.yaml** updates (as above)
1. Perform any required **codes.yaml** and TRAPI **versions.yaml** updates (as above)
2. Run the unit test suite to ensure that nothing fails. Iterate to fix failures (in the code or in terms of revised unit tests to reflect fresh code designs)
3. Document release changes in the **CHANGELOG.md**
4. Update the **`[Tool Poetry]version =`** field in the **pyprojects.yaml**, e.g. "3.8.3"
4. Update the **`[Tool Poetry]version =`** field in the **pyprojects.yaml**, e.g. "3.8.8"
5. Run **`poetry update`** (preferably within **`poetry shell`**)
6. Commit or pull request merge all files (including the **poetry.lock** file) to **master**
7. Add the equivalent Git **tag** to **master**. This should be the Semantic Version string from step 4 with an added 'v' prefix, i.e. "v3.8.3".
Expand Down
14 changes: 7 additions & 7 deletions poetry.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[tool.poetry]
name = "reasoner-validator"
version = "3.8.7"
version = "3.8.8"
description = "Validation tools for Reasoner API"
authors = [
"Richard Bruskiewich <[email protected]>",
Expand Down

0 comments on commit 588e0c5

Please sign in to comment.