Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(common-lib): initialize array to avoid reducing empty array error #356

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

Tzal3x
Copy link
Collaborator

@Tzal3x Tzal3x commented Jan 15, 2025

We are currently getting errors for trying to reduce an empty array.

Checking the filtered routes result will resolve this.

@Tzal3x Tzal3x added bug Something isn't working common-library labels Jan 15, 2025
@Tzal3x Tzal3x requested a review from chariskms January 15, 2025 17:43
@Tzal3x Tzal3x self-assigned this Jan 15, 2025
Copy link

vercel bot commented Jan 15, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
walrus-sites-sp ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 15, 2025 6:25pm
walrus-sites-sp-testnet ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 15, 2025 6:25pm
walrus-sites-sw-testnet ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 15, 2025 6:25pm

Copy link

codspeed-hq bot commented Jan 15, 2025

CodSpeed Performance Report

Merging #356 will not alter performance

Comparing alextzimas/fix-error-reduce-of-empty-array (0841e36) with main (8b8c1c8)

Summary

✅ 3 untouched benchmarks

@Tzal3x Tzal3x merged commit 8dba022 into main Jan 16, 2025
21 checks passed
@Tzal3x Tzal3x deleted the alextzimas/fix-error-reduce-of-empty-array branch January 16, 2025 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working common-library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants