Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(server-portal): unregister past service workers with script injection #334

Conversation

Tzal3x
Copy link
Collaborator

@Tzal3x Tzal3x commented Dec 18, 2024

No description provided.

Copy link

vercel bot commented Dec 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
walrus-sites-sp ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 19, 2024 1:53pm
walrus-sites-sp-testnet ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 19, 2024 1:53pm
walrus-sites-sw ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 19, 2024 1:53pm
walrus-sites-sw-testnet ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 19, 2024 1:53pm

Copy link

codspeed-hq bot commented Dec 18, 2024

CodSpeed Performance Report

Merging #334 will not alter performance

Comparing alextzimas/seint-447-unregister-the-the-service-worker-from-walrussite (7bd5dd9) with main (7899e4b)

Summary

✅ 3 untouched benchmarks

This is done so that a walrus site
can still use its' own service worker.
@Tzal3x
Copy link
Collaborator Author

Tzal3x commented Dec 19, 2024

This approach is wrong and it doesn't work. Closing the PR.

@Tzal3x Tzal3x closed this Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
server-portal A label for the server-side portal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant