Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: derive Routes df ID instead of fetch #332

Closed
wants to merge 21 commits into from
Closed

feat: derive Routes df ID instead of fetch #332

wants to merge 21 commits into from

Conversation

Tzal3x
Copy link
Collaborator

@Tzal3x Tzal3x commented Dec 18, 2024 •
edited
Loading

  • TODO: need to double check that this works.

Tzal3x and others added 20 commits December 10, 2024 13:45
@Tzal3x
Integrate Sentry only on production
8416e04
@Tzal3x
Create custom_blocklist_checker abstraction
60df9fa
@Tzal3x
Enable sentry and blocklist separately using custom env vars
5d26508
@Tzal3x
Add RPC_URL_LIST env var to SW config
0641dbf
@Tzal3x
Refactor: create PageFetcher
22c1011
@Tzal3x
Remove singleton implementation of RPCSelector
1b04b8c
@Tzal3x
Fix env var to RPC_URL_LIST
f683f40
@Tzal3x
Create ResourceFetcher
f5890b9
@Tzal3x
Rename rpcSelectorSingleton to rpcSelector
e7771ef
@Tzal3x
Compose: RPCSelector -> ResourceFetcher
05e45db
@Tzal3x
Merge branch 'main' into alextzimas/refactor-common-lib-move-to-ooo
87fec2c
@Tzal3x
Fix test - new mock for rpcSelector
73b71db
@Tzal3x
Create SuiNSResolver - BREAKING service worker FIXME
560590a
@Tzal3x
Create WalrusSitesRouter
dd0e162
@Tzal3x
Fix webpack config - load env variables explicitly
9e9bd65
@Tzal3x
Remove unused reemnant of rpcselector
34ea37d
@Tzal3x @giac-mysten
feat(server-portal): create ConfigurationLoader (#327)
b714475 
A utility class that makes it safer to load the environment
variables of the project.

By using this class, we can ensure that the environment
variables are loaded correctly and their data types are
correct.

---------

Co-authored-by: giac-mysten <[email protected]>
@Tzal3x @github-advanced-security
Fix code scanning alert no. 2: Incomplete string escaping or encoding
c956eaa 
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
@Tzal3x
Rename checkForErrors to checkRedirectLimits
286fc92
@Tzal3x
Rename PageFetcher to UrlFetcher
46031da 
Update its' functions to depict the
new name.
@Tzal3x Tzal3x self-assigned this Dec 18, 2024
@vercel Vercel
Copy link

vercel bot commented Dec 18, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
walrus-sites-sp ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 18, 2024 0:22am
walrus-sites-sp-testnet ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 18, 2024 0:22am
walrus-sites-sw ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 18, 2024 0:22am
walrus-sites-sw-testnet ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 18, 2024 0:22am

@Tzal3x Tzal3x requested a review from chariskms December 18, 2024 11:09
@Tzal3x Tzal3x mentioned this pull request Dec 18, 2024
Merged
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Dec 18, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #332 will not alter performance

Comparing alextzimas/derive-routes-df-instead-of-fetch (738fed7) with alextzimas/refactor-common-lib-move-to-ooo (46031da)

Summary

✅ 3 untouched benchmarks

@Tzal3x Tzal3x changed the base branch from main to alextzimas/refactor-common-lib-move-to-ooo December 18, 2024 11:12
@Tzal3x Tzal3x changed the title feat: derive Routes df instead of fetch feat: derive Routes df ID instead of fetch Dec 18, 2024
@Tzal3x Tzal3x force-pushed the alextzimas/derive-routes-df-instead-of-fetch branch from 890e48d to 738fed7 Compare December 18, 2024 12:21
Base automatically changed from alextzimas/refactor-common-lib-move-to-ooo to main December 18, 2024 13:44
@Tzal3x Tzal3x closed this Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chariskms chariskms Awaiting requested review from chariskms

Assignees

@Tzal3x Tzal3x

Labels
common-library performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Tzal3x