-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(site-builder): add new package to config, expose destroy command #318
Conversation
Signed-off-by: giac-mysten <[email protected]>
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
CodSpeed Performance ReportMerging #318 will not alter performanceComparing Summary
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sweet! Thank you 🙇♂️ Some newborn questions:
- This only deletes already "expired" sites right? Sites that the blob of the resources have been gone past their epoch expiration, so they are deleted. And the user just wants to take the reimbursement by deleting the no-longer needed sui objects.
- If a user needs to delete a site, before that expiring, this functionality is not supported yet in the
site-builder
right? Meaning that during publishing he should define the resource blobs as deleteable, delete them, and then have a separate function (maybe different than destroy?) that deletes the blobs first, and then callingsite-builder destroy
?
Ah this is actually an excellent point. Currently, the destroy command does not touch the blobs on walrus. Only removes the Site object and dynamic fields from Sui. Which may not be what people want. However, we do not support deletable sites at the moment. So a bit more thinking may be actually needed here to decide what is best to do. Possibly a good idea would be to always publish sites as deletable blobs, unless someone explicitly adds the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, let's merge this and we then can proceed by building the deletable blobs functionality in a following PR.
Closes SEINT-357
Closes SEINT-371