indexer-alt: tx and cp signature-related schema changes #20915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Description We need access to transaction signatures to form the RPC response. Originally we were indexing `SenderSignedData` and decided this was not a good idea, but then we forgot to add the signatures back in their own field. ## Test plan Run the indexer locally and inspect its output for signatures.
## Description Split out `kv_checkpoint`'s `certified_checkpoint` field into a `checkpoint_summary` and its `signatures`, to match the schema used by the KV store. ## Test plan Run the indexer and inspect the results.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
amnn
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
lxfind
reviewed
Jan 17, 2025
crates/sui-indexer-alt-schema/migrations/2025-01-16-231500_tx_signatures/up.sql
Outdated
Show resolved
Hide resolved
crates/sui-indexer-alt-schema/migrations/2025-01-17-180320_cp_signatures/up.sql
Outdated
Show resolved
Hide resolved
amnn
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
|
All comments should be resolved now -- would appreciate another look! |
lxfind
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
kv_checkpoints.certified_checkpointinto the summary structure and separately the signature, this was done to match the KV store's schema for checkpoints.kv_transactions.raw_signatures, because I realised while trying to implement transaction RPC endpoints that we need the signature and we don't have them anywhere.Test plan
Run the indexer locally with the
kv_checkpointsandkv_transactionspipelines enabled, and check the data in the DB.Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.