Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[consensus] advance threshold clock from dag state #20906

Merged
merged 2 commits into from
Jan 17, 2025
Merged

Conversation

mwtian
Copy link
Member

@mwtian mwtian commented Jan 16, 2025

Description

Updates threshold clock when blocks are accepted into dag state, so consistency between threshold clock and dag state are easily maintained.

Test plan

CI


Release notes

Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.

For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.

  • Protocol:
  • Nodes (Validators and Full nodes):
  • gRPC:
  • JSON-RPC:
  • GraphQL:
  • CLI:
  • Rust SDK:

@mwtian mwtian requested a review from a team as a code owner January 16, 2025 18:26
Copy link

vercel bot commented Jan 16, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sui-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 17, 2025 4:24pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
multisig-toolkit ⬜️ Ignored (Inspect) Visit Preview Jan 17, 2025 4:24pm
sui-kiosk ⬜️ Ignored (Inspect) Visit Preview Jan 17, 2025 4:24pm

@mwtian mwtian temporarily deployed to sui-typescript-aws-kms-test-env January 16, 2025 18:26 — with GitHub Actions Inactive
@mwtian mwtian force-pushed the tmw/threshold-clock branch from 75d3d6c to 0020c99 Compare January 16, 2025 18:28
@mwtian mwtian temporarily deployed to sui-typescript-aws-kms-test-env January 16, 2025 18:29 — with GitHub Actions Inactive
@mwtian mwtian marked this pull request as draft January 16, 2025 18:30
@mwtian mwtian force-pushed the tmw/threshold-clock branch from 0020c99 to 9d0c391 Compare January 17, 2025 05:17
@mwtian mwtian temporarily deployed to sui-typescript-aws-kms-test-env January 17, 2025 05:17 — with GitHub Actions Inactive
@mwtian mwtian marked this pull request as ready for review January 17, 2025 05:17
@mwtian mwtian temporarily deployed to sui-typescript-aws-kms-test-env January 17, 2025 05:17 — with GitHub Actions Inactive
Copy link
Contributor

@akichidis akichidis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍 Close to some of the changes when I attempted to refactor Threshold clock in DagState but this PR has some nice simplifications.

@mwtian mwtian temporarily deployed to sui-typescript-aws-kms-test-env January 17, 2025 16:22 — with GitHub Actions Inactive
@mwtian mwtian enabled auto-merge (squash) January 17, 2025 16:22
@mwtian mwtian merged commit 5af9664 into main Jan 17, 2025
51 checks passed
@mwtian mwtian deleted the tmw/threshold-clock branch January 17, 2025 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants