Add new object_per_epoch_marker_table that includes consensus start versions
#20822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Skipped Deployments
|
aschran
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
aschran
force-pushed
the
aschran/cov2-marker2
branch
from
5c81509 to
af1187c
Compare
aschran
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
aschran
force-pushed
the
aschran/cov2-marker2
branch
from
af1187c to
2c62066
Compare
aschran
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
aschran
force-pushed
the
aschran/cov2-marker2
branch
from
2c62066 to
58cb35e
Compare
aschran
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
… versions This introduces the concept of a "FullObjectID" and "FullObjectKey", which for consensus objects includes the initial shared version/start version. Migrates to these new types across the codebase where relevant.
aschran
force-pushed
the
aschran/cov2-marker2
branch
from
58cb35e to
4161327
Compare
aschran
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
mystenmark
reviewed
Jan 10, 2025
| @@ -303,6 +307,8 @@ pub trait ObjectCacheRead: Send + Sync { | |||
| input_key | |||
| ); | |||
| // If the key exists at the specified version, then the object is available. | |||
| // TODO-DNS does this need to be inverted to check markers first, so that it doesn't incorrectly load | |||
There was a problem hiding this comment.
and i think the answer is yes, clearly
There was a problem hiding this comment.
noting for posterity per offline discussion - this function is correct as-is, and when implementing execution logic for consensusv2 we'll need to add code to check after the object is loaded that the object owner is what we expect based on tx input args
mystenmark
reviewed
Jan 10, 2025
mystenmark
reviewed
Jan 10, 2025
| @@ -43,6 +43,7 @@ pub struct TemporaryStore<'backing> { | |||
| store: &'backing dyn BackingStore, | |||
| tx_digest: TransactionDigest, | |||
| input_objects: BTreeMap<ObjectID, Object>, | |||
| deleted_consensus_objects: BTreeMap<ObjectID, SequenceNumber>, | |||
There was a problem hiding this comment.
why do older execution versions need this new code? they don't appear to use it
There was a problem hiding this comment.
they use it to construct the InnerTemporaryStore which is not part of the versioned sui-execution crate
mystenmark
reviewed
Jan 10, 2025
| version, | ||
| self.current_epoch_id, | ||
| self.protocol_config | ||
| .use_object_per_epoch_marker_table_v2_as_option() |
There was a problem hiding this comment.
nit: isn't there a getter without the option that would just return false?
There was a problem hiding this comment.
I don't think so? from the macro:
let getter = quote! {
// Derive the getter
pub fn #field_name(&self) -> #inner_type {
self.#field_name.expect(Self::CONSTANT_ERR_MSG)
}
pub fn #as_option_name(&self) -> #field_type {
self.#field_name
}
};
mystenmark
reviewed
Jan 10, 2025
mystenmark
reviewed
Jan 10, 2025
aschran
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
aschran
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces the concept of a "FullObjectID" and "FullObjectKey", which for consensus objects includes the initial shared version/start version.
Migrates to these new types across the codebase where relevant.
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.