Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nit] Minor improvements to Object::new_coin #20771

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lxfind
Copy link
Contributor

@lxfind lxfind commented Jan 3, 2025

Description

This PR improves a few styles for clarity:

  1. new_coin API should take the type_tag of the coin directly, instead of allowing arbitrary move types.
  2. the implementation of new_coin API should use Coin instead of GasCoin, since it's not guaranteed to be a GasCoin.
  3. Some other type improvements

Test plan

CI


Release notes

Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.

For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.

  • Protocol:
  • Nodes (Validators and Full nodes):
  • gRPC:
  • JSON-RPC:
  • GraphQL:
  • CLI:
  • Rust SDK:

@lxfind lxfind requested a review from joyqvq as a code owner January 3, 2025 18:47
@lxfind lxfind requested review from bmwill and removed request for joyqvq January 3, 2025 18:47
Copy link

vercel bot commented Jan 3, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sui-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 3, 2025 7:20pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
multisig-toolkit ⬜️ Ignored (Inspect) Visit Preview Jan 3, 2025 7:20pm
sui-kiosk ⬜️ Ignored (Inspect) Visit Preview Jan 3, 2025 7:20pm
sui-typescript-docs ⬜️ Ignored (Inspect) Visit Preview Jan 3, 2025 7:20pm

@lxfind lxfind temporarily deployed to sui-typescript-aws-kms-test-env January 3, 2025 18:47 — with GitHub Actions Inactive
@lxfind lxfind requested review from amnn and dariorussi January 3, 2025 18:47
@lxfind lxfind force-pushed the object-coin-test-constructor-improve branch from f8aa38c to 50a986a Compare January 3, 2025 19:19
@lxfind lxfind temporarily deployed to sui-typescript-aws-kms-test-env January 3, 2025 19:19 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant