You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a user sets a nickname in their Sui wallet and later applies for a domain name, the domain name does not display, leading to confusion about whether it is active. Additionally, there is no direct way for users to view or manage their domain name in the wallet interface. see #20409
Enhanced the wallet’s domain name display logic to provide a seamless way to show domain names, even if the user has already set a nickname. The improvements are as follows:
When the user clicks “EDIT NICKNAME,” the domain name is displayed as an option, allowing the user to choose whether to display the domain name or continue using the nickname.
Test plan
Tested the scenario where both a nickname and a domain name are set to ensure the UI includes functionality to display either the domain name or the nickname, allowing users to switch between them.
Tested the scenario where only a nickname is set to verify the nickname displays correctly and the user address remains accessible.
Tested the scenario where neither a nickname nor a domain name is set to ensure the user address displays by default.
default.mp4
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.
yjshi2015
changed the title
Sui Feature Request - Minor bug with domain display in wallet #20409
Sui Feature Request - Minor bug with domain display in wallet
Nov 24, 2024
yjshi2015
changed the title
Sui Feature Request - Minor bug with domain display in wallet
[Wallet] Feature - Minor bug with domain display in wallet
Dec 7, 2024
yjshi2015
changed the title
[Wallet] Feature - Minor bug with domain display in wallet
[Wallet] Fix display inconsistency for domain names when nickname is set
Dec 7, 2024
Hi @pchrysochoidis, @mystieanwaya, @mamos-mysten, could you kindly review this PR when you have a chance? It addresses the issue where domain names do not display if a nickname is already set, causing user confusion. This PR implements a feature that allows users to choose between displaying their domain name or nickname when editing, improving the wallet’s usability. Thanks!
Hey @yjshi2015, first of all thank you for the contribution! We're current working on a major update to the extension that will be released soon. As such, we're not planning any releases for the current extension other than for critical bugfixes.
I've made a ticket internally to track this request so that we can make sure this issue is correctly resolved with the updated version of the extension.
Hey @yjshi2015, first of all thank you for the contribution! We're current working on a major update to the extension that will be released soon. As such, we're not planning any releases for the current extension other than for critical bugfixes.
I've made a ticket internally to track this request so that we can make sure this issue is correctly resolved with the updated version of the extension.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
yjshi2015
requested review from
pchrysochoidis and
mystieanwaya
and removed request for
a team
Description
If a user sets a nickname in their Sui wallet and later applies for a domain name, the domain name does not display, leading to confusion about whether it is active. Additionally, there is no direct way for users to view or manage their domain name in the wallet interface. see #20409
Enhanced the wallet’s domain name display logic to provide a seamless way to show domain names, even if the user has already set a nickname. The improvements are as follows:
When the user clicks “EDIT NICKNAME,” the domain name is displayed as an option, allowing the user to choose whether to display the domain name or continue using the nickname.
Test plan
Tested the scenario where both a nickname and a domain name are set to ensure the UI includes functionality to display either the domain name or the nickname, allowing users to switch between them.
Tested the scenario where only a nickname is set to verify the nickname displays correctly and the user address remains accessible.
Tested the scenario where neither a nickname nor a domain name is set to ensure the user address displays by default.
default.mp4
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.