ts sdk: coin-with-balance intent create zero coin on zero amount #20184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Skipped Deployments
|
kklas
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
hayes-mysten
reviewed
Nov 5, 2024
| if (balance === 0n) { | ||
| transactionData.replaceCommand( | ||
| index, | ||
| Commands.MoveCall({ target: '0x2::coin::zero', typeArguments: [type] }), |
There was a problem hiding this comment.
I didn't know this was possible, very cool!
hayes-mysten
reviewed
Nov 5, 2024
hayes-mysten
approved these changes
Nov 5, 2024
hayes-mysten
reviewed
Nov 5, 2024
hayes-mysten
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
|
Just missing a changeset, but this seems like a great improvement |
|
Added changeset |
kklas
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Change the
coinWithBalanceintent so that it creates a zero coin instead of splitting when amount is 0. This fixes the edge case where the user doesn't have a coin of required type in the wallet but the amount is 0 anyways, thus avoids throwing theNot enough coins of type ${coinType} to satisfy requested balanceerror in this situationcc @hayes-mysten
Test plan
Added e2e tests
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.