remove TxContext from the executor API #20000
Draft
+78
−41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Skipped Deployments
|
|
20000!!! |
and it's mine!!! |
dariorussi
commented
Oct 24, 2024
dariorussi
commented
Oct 24, 2024
dariorussi
force-pushed
the
dario/tx_ctx
branch
from
db9b0f0 to
4b575ae
Compare
dariorussi
force-pushed
the
dario/tx_ctx
branch
from
4b575ae to
b8eb872
Compare
dariorussi
force-pushed
the
dario/tx_ctx
branch
from
b8eb872 to
a4b3820
Compare
dariorussi
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
dariorussi
force-pushed
the
dario/tx_ctx
branch
from
a4b3820 to
4d70b21
Compare
dariorussi
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
dariorussi
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
dariorussi
force-pushed
the
dario/tx_ctx
branch
from
41922dd to
f4ffb2f
Compare
dariorussi
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
dariorussi
force-pushed
the
dario/tx_ctx
branch
from
f4ffb2f to
b3c154d
Compare
dariorussi
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
dariorussi
force-pushed
the
dario/tx_ctx
branch
from
b3c154d to
74f5783
Compare
dariorussi
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
dariorussi
force-pushed
the
dario/tx_ctx
branch
from
74f5783 to
e6d718f
Compare
dariorussi
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
dariorussi
force-pushed
the
dario/tx_ctx
branch
from
e6d718f to
39059c7
Compare
dariorussi
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
bmwill
reviewed
Jan 21, 2025
Comment on lines
882
to
891
| tx_ctx.clone(), | ||
| gas_charger, | ||
| advance_epoch_pt, | ||
| ); | ||
| // advance epoch has a non standard behavior in that it can run multiple `execute` functions | ||
| // with the same `TxContext`. This call updates the `TxContext` to reflect the new objects created. | ||
| // `objects_created_count` may contain the number of packages published as well and in that sense | ||
| // it is not a true count of objects created. However even with that we are growing the `ids_created` | ||
| // and we avoid conflicts anyway even if the range of values is not contiguous (has gaps). | ||
| tx_ctx.add_ids_created(temporary_store.objects_created_count() as u64); |
There was a problem hiding this comment.
This seems fairly error prone to remember to update the ids created from the "older" instance of a context. If we're not careful we'll generate multiple object ids which are identical.
There was a problem hiding this comment.
yes, agree! and this is what the behavior as it has always been. This is just to make it more obvious.
If you have an idea of how to change all of that please let us know. I could not find a good, simple way to do it without reworking the entire space which, at the moment, feels outside the scope of this work.
Also please notice this is all inside execution, so from a "client" perspective no one sees this.
There was a problem hiding this comment.
having said all of that I'll review the usage of TxContext and see is there is another way to plug that in cleanly
dariorussi
force-pushed
the
dario/tx_ctx
branch
from
39059c7 to
2e2c9b0
Compare
dariorussi
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
dariorussi
force-pushed
the
dario/tx_ctx
branch
from
2e2c9b0 to
f4a9f76
Compare
dariorussi
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe the changes or additions included in this PR.
Test plan
How did you test the new or updated feature?
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.