Skip to content

Commit

Permalink
[consensus increase round prober default timeout to 4s (#20862)
Browse files Browse the repository at this point in the history
## Description 

It should be ok to exclude responses when they are taking >= 2s to
return, for quorum round calculations. But it seems better to use a
longer timeout to reduce variance in the computed quorum rounds among
validators.

## Test plan 

CI

---

## Release notes

Check each box that your changes affect. If none of the boxes relate to
your changes, release notes aren't required.

For each box you select, include information after the relevant heading
that describes the impact of your changes that a user might notice and
any actions they must take to implement updates.

- [ ] Protocol: 
- [ ] Nodes (Validators and Full nodes): 
- [ ] gRPC:
- [ ] JSON-RPC: 
- [ ] GraphQL: 
- [ ] CLI: 
- [ ] Rust SDK:
  • Loading branch information
mwtian authored Jan 11, 2025
1 parent a6bd6e8 commit f599881
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion consensus/config/src/parameters.rs
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ impl Parameters {
if cfg!(msim) {
800
} else {
2000
4000
}
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ sync_last_known_own_block_timeout:
secs: 5
nanos: 0
round_prober_interval_ms: 5000
round_prober_request_timeout_ms: 2000
round_prober_request_timeout_ms: 4000
propagation_delay_stop_proposal_threshold: 5
dag_state_cached_rounds: 500
commit_sync_parallel_fetches: 8
Expand Down

0 comments on commit f599881

Please sign in to comment.