[DKG] Clean up old versions of DKG & ECIES #845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
benr-ml
commented
Nov 3, 2024
•
benr-ml
commented
- add a regression test to ecies_v1
- remove dkg_v0 and ecies_v0, and move the shared code to *_v1 (namely structs and Party::new)
- remove dkg_v0 and ecies_v0, and move the shared code to *_v1
jonas-lj
approved these changes
Nov 11, 2024
| // TODO: needs to use ecies_v1 | ||
| // #[cfg(test)] | ||
| // #[path = "tests/nidkg_tests.rs"] | ||
| // pub mod nidkg_tests; |
There was a problem hiding this comment.
Is this commented out on purpose?
There was a problem hiding this comment.
yes, added a todo to fix the APIs if needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.