Skip to content
This repository has been archived by the owner on Jul 16, 2024. It is now read-only.

Update sui.js to latest #94

Closed
wants to merge 1 commit into from
Closed

Update sui.js to latest #94

wants to merge 1 commit into from

Conversation

Tzal3x
Copy link
Collaborator

@Tzal3x Tzal3x commented Nov 16, 2023

No description provided.

@Tzal3x Tzal3x requested a review from teohaik November 16, 2023 11:47
@Tzal3x Tzal3x linked an issue Nov 16, 2023 that may be closed by this pull request
Update sui.js to latest version #93
Closed
@Tzal3x
Copy link
Collaborator Author

Tzal3x commented Nov 16, 2023 •
edited
Loading

Looking into the logs of the failed CI build it seems to be something wrong with the latest @mysten/bcs version.

Run npm run build --if-present

> [email protected] build
> pnpm build:types && pnpm build:tsup


> [email protected] build:types /home/runner/work/Sui_Owned_Object_Pools/Sui_Owned_Object_Pools
> tsc --build

Error: node_modules/@mysten/bcs/dist/bcs.d.ts(105,11): error TS1139: Type parameter declaration expected.
Error: node_modules/@mysten/bcs/dist/bcs.d.ts(105,23): error TS1005: ',' expected.
Error: node_modules/@mysten/bcs/dist/bcs.d.ts(105,40): error TS1005: ',' expected.
Error: node_modules/@mysten/bcs/dist/bcs.d.ts(105,47): error TS1005: ',' expected.
Error: node_modules/@mysten/bcs/dist/bcs.d.ts(105,51): error TS1005: '>' expected.
Error: node_modules/@mysten/bcs/dist/bcs.d.ts(105,[6](https://github.com/MystenLabs/Sui_Owned_Object_Pools/actions/runs/6890277639/job/18742976809?pr=94#step:6:7)6): error TS1005: ')' expected.
Error: node_modules/@mysten/bcs/dist/bcs.d.ts(105,83): error TS1109: Expression expected.
Error: node_modules/@mysten/bcs/dist/bcs.d.ts(105,28[7](https://github.com/MystenLabs/Sui_Owned_Object_Pools/actions/runs/6890277639/job/18742976809?pr=94#step:6:8)): error TS[10](https://github.com/MystenLabs/Sui_Owned_Object_Pools/actions/runs/6890277639/job/18742976809?pr=94#step:6:11)05: ';' expected.
...

It was working just fine at "@mysten/bcs": "0.7.4", but fails at "@mysten/bcs": "0.8.1".

VLegakis
VLegakis reviewed Nov 22, 2023
View reviewed changes
package.json
@@ -46,7 +46,7 @@
"Theodore Chaikalis (https://github.com/teohaik)"
],
"dependencies": {
"@mysten/sui.js": "^0.42.0",
"@mysten/sui.js": "^0.46.1",
"@typescript-eslint/eslint-plugin": "5.59.11",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typescript-eslint/eslint-plugin could also be moved to dev dependencies.
On the other hand ts-node should be moved to the normal dependencies I think (not 100% sure about that)

@Tzal3x Tzal3x marked this pull request as draft November 24, 2023 08:24
@Tzal3x Tzal3x mentioned this pull request Jan 12, 2024
Closed
@Tzal3x Tzal3x changed the title Upgrade sui.js to 0.46.1 Upgrade sui.js to latest Jan 12, 2024
@Tzal3x
Copy link
Collaborator Author

Tzal3x commented Jan 16, 2024

Closing this PR since the code got deprecated and it's too much work to rebase it. Continuing here: #133

@Tzal3x Tzal3x closed this Jan 16, 2024
@Tzal3x Tzal3x changed the title Upgrade sui.js to latest Update sui.js to latest Jan 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@VLegakis VLegakis VLegakis left review comments

@teohaik teohaik Awaiting requested review from teohaik

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update sui.js to latest version
2 participants
@Tzal3x @VLegakis