dev(compiler): add actor for watch compiler #371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ at low-level + state-based detection
| // Accumulate events. | ||
| let mut need_recompile = false; | ||
| need_recompile = self.process(event, &compiler_ack) || need_recompile; | ||
| while let Some(event) = fs_rx |
There was a problem hiding this comment.
i'd prefer breaking nested code here into 3 whiles. But... it's not my code so do it as you wish
| let TaggedMemoryEvent { | ||
| logical_tick, | ||
| event, | ||
| } = *event.downcast().unwrap(); |
There was a problem hiding this comment.
downcast().unwrap()? seems that u r pretty sure what the underlying type is. It is possible to make it static? box<dyn any> is super ugly
| steal_send: mpsc::UnboundedSender<BorrowTask<Ctx>>, | ||
| memory_send: mpsc::UnboundedSender<MemoryEvent>, | ||
|
|
||
| _ctx: std::marker::PhantomData<Ctx>, |
| } | ||
|
|
||
| /// Update the watches of corresponding files. | ||
| fn update_watches(&mut self, paths: &[ImmutPath]) -> Option<FileChangeSet> { |
There was a problem hiding this comment.
I don't quite understand why unwatch + rewatch works? What problem does it solve?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.