-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโll occasionally send you account related emails.
Already on GitHub? Sign in to your account
User credit result/#91 #93
Conversation
๐storybook: https://65ccb85d5afe55a024495bc0-qantdwpvyv.chromatic.com/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
empty data container์ ์๋์ ์ด์ ๋ก ์ญ์ ํ๊ณ LectureSearch ์ปดํฌ๋ํธ์ ํฉ์ณค๋๋ฐ ํ์๋ถ๋ค ์๊ฐ์ ์ด๋ ์ ๊ฐ์!?
์ฐ๋ ค๋๋ ๋ฌธ์ ๋ ์์๋์ง์๋ค์. ์ข์๋ณด์ ๋๋ค.
@@ -13,7 +13,7 @@ export default async function UserInfoNavigator() { | |||
<span className="font-semibold">{userInfo.studentName}</span> | |||
<span>๋</span> | |||
</div> | |||
<div className="mb-3 text-sm">{userInfo.major}</div> | |||
<div className="mb-3 text-sm">{userInfo.completionDivision[0].major}</div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
์ฃผ์ ๊ณต ํ๋๋ง ๋ ธ์ถํ์ค ๊ณํ์ด์ ๊ฐ์?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
์ ์ด๊ฑฐ๋ mock ๋ฐ์ดํฐ๋ฅผ ๋ฐ๊พธ๋ฉด์ ์ค๋ฅ๊ฐ ๋์ง ์๊ฒ๋ ๋ฐ๊พผ ๊ฒ์ด๊ณ ์ด๋ค ๊ฑฐ ๋ ธ์ถํ ์ง๋ user info navigator ๋ด๋นํ์ ๋ถ์ด ์์ ํ์ง ์์๊น์ถ์ต๋๋ค..!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- ์๊ณ ํ์ จ์ต๋๋ค
const emptyDataRender = () => { | ||
return ( | ||
<div className="flex flex-col items-center justify-center gap-4"> | ||
<Image src={searchResultIcon} alt="search-result-icon" width={40} height={40} /> | ||
<div className="text-md font-medium text-gray-400 text-center whitespace-pre-wrap"> | ||
๊ฒ์ ๊ฒฐ๊ณผ๊ฐ ํ์๋ฉ๋๋ค | ||
<br />ํ ๊ธ์ ์ด์ ๊ฒ์ํด์ฃผ์ธ์ | ||
</div> | ||
</div> | ||
); | ||
}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- ์ ์ ํด ๋ณด์ด๋ค์
๐ ์์ ๋ด์ฉ
close #91
๐ค ๊ณ ๋ฏผ ํ๋ ๋ถ๋ถ