refactor: change calculate remainCredit

Myongji-Graduate · Sep 13, 2024 · e8e5023 · e8e5023
1 parent 5a0c9ca
commit e8e5023
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/app/ui/user/user-info-card/user-info-content.tsx b/app/ui/user/user-info-card/user-info-content.tsx
@@ -16,8 +16,10 @@ function UserInfoContent({ data }: UserInfoContentProps) {
   const { studentNumber, studentName, completeDivision: majors, totalCredit, takenCredit, graduated } = data;
 
   const remainCredit = categories.reduce((accumulator, category) => {
-    if (category.category === 'CHAPEL') return accumulator;
-    return accumulator + (category.totalCredit - category.takenCredit);
+    const { category: categoryName, totalCredit, takenCredit } = category;
+    if (categoryName === 'CHAPEL') return accumulator;
+    const categoryRemainCredit = totalCredit - takenCredit < 0 ? 0 : totalCredit - takenCredit;
+    return accumulator + categoryRemainCredit;
   }, 0);
 
   const percentage = getPercentage(totalCredit - remainCredit, totalCredit);