MCR-3302 fix edge cases for MCRCategoryID.fromString() #2327
+47
−26
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to jira.
This pull request includes several changes to improve the handling of category IDs and update the testing framework in the
mycore-base
module. The most important changes include adding a new JUnit dependency, refactoring thefromString
method inMCRCategoryID
, and updating the tests to use JUnit 5.Dependency Updates:
junit-jupiter-params
dependency topom.xml
for parameterized tests.Code Refactoring:
fromString
method inMCRCategoryID
to usesplit
andswitch
instead ofStringTokenizer
for better readability and error handling.StringTokenizer
fromMCRCategoryID.java
.Testing Updates:
MCRCategoryIDTest
to use JUnit 5 annotations and methods, includingassertThrows
for exception testing. [1] [2]MCRCategoryIDTest
.