show federation popups

MutinyWallet · May 8, 2024 · de028bc · de028bc
1 parent fa9b0c0
commit de028bc
Show file tree

Hide file tree

Showing 8 changed files with 115 additions and 94 deletions.
diff --git a/public/i18n/en.json b/public/i18n/en.json
@@ -565,7 +565,8 @@
       "join_me": "Join me",
       "recommend": "Recommend federation",
       "recommended_by_you": "Recommended by you",
-      "transfer_funds": "Transfer funds"
+      "transfer_funds": "Transfer funds",
+      "transfer_funds_message": "Add a second federation to enable transfers."
     },
     "gift": {
       "give_sats_link": "Give sats as a gift",

diff --git a/src/components/Activity.tsx b/src/components/Activity.tsx
@@ -8,7 +8,6 @@ import {
     createSignal,
     For,
     Match,
-    onMount,
     Show,
     Suspense,
     Switch
@@ -19,6 +18,7 @@ import {
     Button,
     ButtonCard,
     ContactButton,
+    FederationPopup,
     LoadingShimmer,
     NiceP,
     SimpleDialog
@@ -375,7 +375,7 @@ function NewContactModal(props: { profile: PseudoContact; close: () => void }) {
 }
 
 export function CombinedActivity() {
-    const [state, actions, sw] = useMegaStore();
+    const [state, _actions, sw] = useMegaStore();
     const i18n = useI18n();
 
     const [detailsOpen, setDetailsOpen] = createSignal(false);
@@ -418,17 +418,6 @@ export function CombinedActivity() {
 
     const [newContact, setNewContact] = createSignal<PseudoContact>();
 
-    const [
-        showFederationExpirationWarning,
-        setShowFederationExpirationWarning
-    ] = createSignal(false);
-
-    onMount(() => {
-        if (state.expiration_warning) {
-            setShowFederationExpirationWarning(true);
-        }
-    });
-
     return (
         <>
             <Show when={detailsId() && detailsKind()}>
@@ -447,30 +436,7 @@ export function CombinedActivity() {
             </Show>
             <Suspense fallback={<LoadingShimmer />}>
                 <Show when={state.expiration_warning}>
-                    <SimpleDialog
-                        title={i18n.t("activity.federation_message")}
-                        open={showFederationExpirationWarning()}
-                        setOpen={(open: boolean) => {
-                            if (!open) {
-                                setShowFederationExpirationWarning(false);
-                                actions.clearExpirationWarning();
-                            }
-                        }}
-                    >
-                        <NiceP>
-                            {state.expiration_warning?.expiresMessage}
-                        </NiceP>
-                        <ButtonCard
-                            onClick={() => navigate("/settings/federations")}
-                        >
-                            <div class="flex items-center gap-2">
-                                <Users class="inline-block text-m-red" />
-                                <NiceP>
-                                    {i18n.t("profile.manage_federation")}
-                                </NiceP>
-                            </div>
-                        </ButtonCard>
-                    </SimpleDialog>
+                    <FederationPopup />
                 </Show>
                 <Show when={!state.has_backed_up}>
                     <ButtonCard

diff --git a/src/components/FederationPopup.tsx b/src/components/FederationPopup.tsx
@@ -0,0 +1,45 @@
+import { useNavigate } from "@solidjs/router";
+import { Users } from "lucide-solid";
+import { createSignal } from "solid-js";
+
+import { ButtonCard, NiceP, SimpleDialog } from "~/components/layout";
+import { useI18n } from "~/i18n/context";
+import { useMegaStore } from "~/state/megaStore";
+
+export function FederationPopup() {
+    const [state, actions, _sw] = useMegaStore();
+    const [
+        showFederationExpirationWarning,
+        setShowFederationExpirationWarning
+    ] = createSignal(!state.expiration_warning_seen);
+
+    const i18n = useI18n();
+    const navigate = useNavigate();
+
+    return (
+        <SimpleDialog
+            title={i18n.t("activity.federation_message")}
+            open={showFederationExpirationWarning()}
+            setOpen={(open: boolean) => {
+                if (!open) {
+                    setShowFederationExpirationWarning(false);
+                    actions.clearExpirationWarning();
+                }
+            }}
+        >
+            <NiceP>{state.expiration_warning?.expiresMessage}</NiceP>
+            <ButtonCard
+                onClick={() => {
+                    actions.clearExpirationWarning();
+                    setShowFederationExpirationWarning(false);
+                    navigate("/settings/federations");
+                }}
+            >
+                <div class="flex items-center gap-2">
+                    <Users class="inline-block text-m-red" />
+                    <NiceP>{i18n.t("profile.manage_federation")}</NiceP>
+                </div>
+            </ButtonCard>
+        </SimpleDialog>
+    );
+}
diff --git a/src/components/index.ts b/src/components/index.ts
@@ -56,3 +56,4 @@ export * from "./EditProfileForm";
 export * from "./ImportNsecForm";
 export * from "./LightningAddressShower";
 export * from "./FederationInviteShower";
+export * from "./FederationPopup";
diff --git a/src/routes/Transfer.tsx b/src/routes/Transfer.tsx
@@ -171,7 +171,11 @@ export function Transfer() {
                         </Match>
                     </Switch>
                 </SuccessModal>
-                <BackLink href="/settings/federations" />
+                <BackLink
+                    title={i18n.t("common.back")}
+                    href="/settings/federations"
+                    showOnDesktop
+                />
                 <LargeHeader>{i18n.t("transfer.title")}</LargeHeader>
                 <div class="flex flex-1 flex-col justify-between gap-2">
                     <div class="flex-1" />

diff --git a/src/routes/settings/ManageFederations.tsx b/src/routes/settings/ManageFederations.tsx
@@ -29,6 +29,7 @@ import {
     ExternalLink,
     FancyCard,
     FederationInviteShower,
+    FederationPopup,
     InfoBox,
     KeyValue,
     LabelCircle,
@@ -40,6 +41,7 @@ import {
     NavBar,
     NiceP,
     showToast,
+    SimpleDialog,
     SubtleButton,
     TextField,
     VStack
@@ -59,6 +61,8 @@ export type MutinyFederationIdentity = {
     federation_expiry_timestamp: number;
     invite_code: string;
     meta_external_url?: string;
+    popup_end_timestamp?: number;
+    popup_countdown_message?: string;
 };
 
 export type Metadata = {
@@ -91,7 +95,7 @@ export function AddFederationForm(props: {
     browseOnly?: boolean;
 }) {
     const i18n = useI18n();
-    const [_state, actions, sw] = useMegaStore();
+    const [state, actions, sw] = useMegaStore();
     const navigate = useNavigate();
     const [error, setError] = createSignal<Error>();
     const [success, setSuccess] = createSignal("");
@@ -181,6 +185,9 @@ export function AddFederationForm(props: {
 
     return (
         <div class="flex w-full flex-col gap-4">
+            <Show when={state.expiration_warning}>
+                <FederationPopup />
+            </Show>
             <Show when={!props.setup && !props.browseOnly}>
                 <MediumHeader>
                     {i18n.t("settings.manage_federations.manual")}
@@ -446,8 +453,15 @@ function FederationListItem(props: {
         setConfirmOpen(true);
     }
 
+    const [transferDialogOpen, setTransferDialogOpen] = createSignal(false);
+
     async function transferFunds() {
-        navigate("/transfer?from=" + props.fed.federation_id);
+        // If there's only one federation we need to let them know to add another
+        if (state.federations?.length && state.federations.length < 2) {
+            setTransferDialogOpen(true);
+        } else {
+            navigate("/transfer?from=" + props.fed.federation_id);
+        }
     }
 
     const [confirmOpen, setConfirmOpen] = createSignal(false);
@@ -457,7 +471,6 @@ function FederationListItem(props: {
         <>
             <FancyCard>
                 <VStack>
-                    {/* <pre>{JSON.stringify(props.fed, null, 2)}</pre> */}
                     <Show when={props.fed.federation_name}>
                         <header class={`font-semibold`}>
                             {props.fed.federation_name}
@@ -466,6 +479,19 @@ function FederationListItem(props: {
                     <Show when={props.fed.welcome_message}>
                         <p>{props.fed.welcome_message}</p>
                     </Show>
+                    <SimpleDialog
+                        title={i18n.t(
+                            "settings.manage_federations.transfer_funds"
+                        )}
+                        open={transferDialogOpen()}
+                        setOpen={setTransferDialogOpen}
+                    >
+                        <NiceP>
+                            {i18n.t(
+                                "settings.manage_federations.transfer_funds_message"
+                            )}
+                        </NiceP>
+                    </SimpleDialog>
                     <Show when={props.balance !== undefined}>
                         <KeyValue
                             key={i18n.t("activity.transaction_details.balance")}
@@ -499,19 +525,10 @@ function FederationListItem(props: {
                             inviteCode={props.fed.invite_code}
                         />
                     </KeyValue>
-                    <Show
-                        when={
-                            state.federations?.length &&
-                            state.federations.length === 2
-                        }
-                    >
-                        <SubtleButton onClick={transferFunds}>
-                            <ArrowLeftRight class="h-4 w-4" />
-                            {i18n.t(
-                                "settings.manage_federations.transfer_funds"
-                            )}
-                        </SubtleButton>
-                    </Show>
+                    <SubtleButton onClick={transferFunds}>
+                        <ArrowLeftRight class="h-4 w-4" />
+                        {i18n.t("settings.manage_federations.transfer_funds")}
+                    </SubtleButton>
                     <Suspense>
                         <RecommendButton fed={props.fed} />
                     </Suspense>

diff --git a/src/state/megaStore.tsx b/src/state/megaStore.tsx
@@ -90,7 +90,8 @@ export const makeMegaStoreContext = () => {
         balanceView: localStorage.getItem("balanceView") || "sats",
         expiration_warning: undefined as
             | { expiresTimestamp: number; expiresMessage: string }
-            | undefined
+            | undefined,
+        expiration_warning_seen: false
     });
 
     const actions = {
@@ -235,43 +236,14 @@ export const makeMegaStoreContext = () => {
                     | { expiresTimestamp: number; expiresMessage: string }
                     | undefined = undefined;
 
-                try {
-                    if (federations.length) {
-                        const activeFederation = federations[0];
-                        const metadataUrl = activeFederation.meta_external_url;
-                        console.log("federation metadata url", metadataUrl);
-                        if (metadataUrl) {
-                            const response = await fetch(metadataUrl);
-                            if (response.ok) {
-                                const metadata = await response.json();
-                                console.log(
-                                    "all federation metadata",
-                                    metadata
-                                );
-                                const specificFederation =
-                                    metadata[activeFederation.federation_id];
-                                console.log(
-                                    "specific federation metadata",
-                                    specificFederation
-                                );
-                                const expiresTimestamp =
-                                    specificFederation.popup_end_timestamp;
-                                console.log(
-                                    "federation expires",
-                                    expiresTimestamp
-                                );
-                                const expiresMessage =
-                                    specificFederation.popup_countdown_message;
-                                expiration_warning = {
-                                    expiresTimestamp,
-                                    expiresMessage
-                                };
-                            }
-                        }
+                federations.forEach((f) => {
+                    if (f.popup_countdown_message && f.popup_end_timestamp) {
+                        expiration_warning = {
+                            expiresTimestamp: f.popup_end_timestamp,
+                            expiresMessage: f.popup_countdown_message
+                        };
                     }
-                } catch (e) {
-                    console.error("Error getting federation metadata", e);
-                }
+                });
 
                 console.log("expiration_warning", expiration_warning);
 
@@ -513,7 +485,21 @@ export const makeMegaStoreContext = () => {
         },
         async refreshFederations() {
             const federations = await sw.list_federations();
-            setState({ federations });
+
+            let expiration_warning:
+                | { expiresTimestamp: number; expiresMessage: string }
+                | undefined = undefined;
+
+            federations.forEach((f) => {
+                if (f.popup_countdown_message && f.popup_end_timestamp) {
+                    expiration_warning = {
+                        expiresTimestamp: f.popup_end_timestamp,
+                        expiresMessage: f.popup_countdown_message
+                    };
+                }
+            });
+
+            setState({ federations, expiration_warning });
         },
         cycleBalanceView() {
             if (state.balanceView === "sats") {
@@ -556,7 +542,7 @@ export const makeMegaStoreContext = () => {
         },
         // Only show the expiration warning once per session
         clearExpirationWarning() {
-            setState({ expiration_warning: undefined });
+            setState({ expiration_warning_seen: true });
         }
     };
 

diff --git a/src/workers/walletWorker.ts b/src/workers/walletWorker.ts
@@ -1362,6 +1362,7 @@ export async function delete_federation_recommendation(
  */
 export async function get_federation_balances(): Promise<FederationBalances> {
     const balances = await wallet!.get_federation_balances();
+    if (!balances) return { balances: [] } as unknown as FederationBalances;
     // PAIN
     // Have to rebuild the balances from the raw data, which is a bit of a pain
     const newBalances: FederationBalance[] = [];