Merge pull request #389 from MurhafSousli/release/14.0.0

v14.0.0
MurhafSousli · Jan 4, 2025 · 4328ef8 · 4328ef8
2 parents 1f38295 + 9a99995
commit 4328ef8
Show file tree

Hide file tree

Showing 46 changed files with 5,457 additions and 4,504 deletions.
diff --git a/.browserslistrc b/.browserslistrc
diff --git a/.editorconfig b/.editorconfig
@@ -1,4 +1,4 @@
-# Editor configuration, see http://editorconfig.org
+# Editor configuration, see https://editorconfig.org
 root = true
 
 [*]
@@ -8,6 +8,9 @@ indent_size = 2
 insert_final_newline = true
 trim_trailing_whitespace = true
 
+[*.ts]
+quote_type = single
+
 [*.md]
 max_line_length = off
 trim_trailing_whitespace = false
diff --git a/.eslintrc.json b/.eslintrc.json
@@ -0,0 +1,47 @@
+{
+  "root": true,
+  "ignorePatterns": [
+    "projects/**/*"
+  ],
+  "overrides": [
+    {
+      "files": [
+        "*.ts"
+      ],
+      "extends": [
+        "eslint:recommended",
+        "plugin:@typescript-eslint/recommended",
+        "plugin:@angular-eslint/recommended",
+        "plugin:@angular-eslint/template/process-inline-templates"
+      ],
+      "rules": {
+        "@angular-eslint/directive-selector": [
+          "error",
+          {
+            "type": "attribute",
+            "prefix": "app",
+            "style": "camelCase"
+          }
+        ],
+        "@angular-eslint/component-selector": [
+          "error",
+          {
+            "type": "element",
+            "prefix": "app",
+            "style": "kebab-case"
+          }
+        ]
+      }
+    },
+    {
+      "files": [
+        "*.html"
+      ],
+      "extends": [
+        "plugin:@angular-eslint/template/recommended",
+        "plugin:@angular-eslint/template/accessibility"
+      ],
+      "rules": {}
+    }
+  ]
+}
diff --git a/.github/workflows/netlify.yml b/.github/workflows/netlify.yml
@@ -16,7 +16,7 @@ jobs:
       - name: Install dependencies
         run: npm ci
       - name: Build demo
-        run: npm run build-demo
+        run: npm run build
       - name: Deploy to Netlify
         uses: nwtgck/[email protected]
         with:

diff --git a/.gitignore b/.gitignore
@@ -1,40 +1,42 @@
 # See http://help.github.com/ignore-files/ for more about ignoring files.
 
-# compiled output
+# Compiled output
 /dist
 /tmp
 /out-tsc
+/bazel-out
 
-# dependencies
+# Node
 /node_modules
+npm-debug.log
+yarn-error.log
 
 # IDEs and editors
-/.idea
+.idea/
 .project
 .classpath
 .c9/
 *.launch
 .settings/
 *.sublime-workspace
 
-# IDE - VSCode
+# Visual Studio Code
 .vscode/*
 !.vscode/settings.json
 !.vscode/tasks.json
 !.vscode/launch.json
 !.vscode/extensions.json
+.history/*
 
-# misc
+# Miscellaneous
 /.angular/cache
-/.sass-cache
+.sass-cache/
 /connect.lock
 /coverage
 /libpeerconnection.log
-npm-debug.log
-yarn-error.log
 testem.log
 /typings
 
-# System Files
+# System files
 .DS_Store
 Thumbs.db
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,10 @@
 # Changelog
 
+## 14.0.0
+
+- Upgrade to Angular 19 (still compatible v17.3.0 and above).
+- fix: `ngProgressHttp` gives an error with http requests inside effects, closes [#386](https://github.com/MurhafSousli/ngx-progressbar/issues/386)
+
 ## 13.0.0
 
 - feat: `NgProgressRef` directive has `(started)` and `(completed)` outputs, instead of subjects.

diff --git a/angular.json b/angular.json
@@ -3,34 +3,6 @@
   "version": 1,
   "newProjectRoot": "projects",
   "projects": {
-    "ngx-progressbar": {
-      "projectType": "library",
-      "root": "projects/ngx-progressbar",
-      "sourceRoot": "projects/ngx-progressbar/src",
-      "prefix": "lib",
-      "architect": {
-        "build": {
-          "builder": "@angular-devkit/build-angular:ng-packagr",
-          "options": {
-            "tsConfig": "projects/ngx-progressbar/tsconfig.lib.json",
-            "project": "projects/ngx-progressbar/ng-package.json"
-          },
-          "configurations": {
-            "production": {
-              "tsConfig": "projects/ngx-progressbar/tsconfig.lib.prod.json"
-            }
-          }
-        },
-        "test": {
-          "builder": "@angular-devkit/build-angular:karma",
-          "options": {
-            "main": "projects/ngx-progressbar/src/test.ts",
-            "tsConfig": "projects/ngx-progressbar/tsconfig.spec.json",
-            "karmaConfig": "projects/ngx-progressbar/karma.conf.js"
-          }
-        }
-      }
-    },
     "ngx-progressbar-demo": {
       "projectType": "application",
       "schematics": {
@@ -45,14 +17,14 @@
         "build": {
           "builder": "@angular-devkit/build-angular:application",
           "options": {
-            "outputPath": {
-              "base": "dist/ngx-progressbar-demo"
-            },
+            "outputPath": "dist/ngx-progressbar-demo",
             "index": "projects/ngx-progressbar-demo/src/index.html",
+            "browser": "projects/ngx-progressbar-demo/src/main.ts",
             "polyfills": [
-              "projects/ngx-progressbar-demo/src/polyfills.ts"
+              "zone.js"
             ],
             "tsConfig": "projects/ngx-progressbar-demo/tsconfig.app.json",
+            "inlineStyleLanguage": "scss",
             "assets": [
               "projects/ngx-progressbar-demo/src/favicon.ico",
               "projects/ngx-progressbar-demo/src/assets"
@@ -61,50 +33,47 @@
               "projects/ngx-progressbar-demo/src/styles.scss"
             ],
             "scripts": [],
-            "extractLicenses": false,
-            "sourceMap": true,
-            "optimization": false,
-            "namedChunks": true,
-            "browser": "projects/ngx-progressbar-demo/src/main.ts"
+            "server": "projects/ngx-progressbar-demo/src/main.server.ts",
+            "prerender": true,
+            "ssr": {
+              "entry": "projects/ngx-progressbar-demo/src/server.ts"
+            }
           },
           "configurations": {
             "production": {
-              "fileReplacements": [
-                {
-                  "replace": "projects/ngx-progressbar-demo/src/environments/environment.ts",
-                  "with": "projects/ngx-progressbar-demo/src/environments/environment.prod.ts"
-                }
-              ],
-              "optimization": true,
-              "outputHashing": "all",
-              "sourceMap": false,
-              "namedChunks": false,
-              "extractLicenses": true,
               "budgets": [
                 {
                   "type": "initial",
                   "maximumWarning": "2mb",
-                  "maximumError": "5mb"
+                  "maximumError": "3mb"
                 },
                 {
                   "type": "anyComponentStyle",
-                  "maximumWarning": "6kb",
-                  "maximumError": "10kb"
+                  "maximumWarning": "15kb",
+                  "maximumError": "15kb"
                 }
-              ]
+              ],
+              "outputHashing": "all"
+            },
+            "development": {
+              "optimization": false,
+              "extractLicenses": false,
+              "sourceMap": true
             }
-          }
+          },
+          "defaultConfiguration": "production"
         },
         "serve": {
           "builder": "@angular-devkit/build-angular:dev-server",
-          "options": {
-            "buildTarget": "ngx-progressbar-demo:build"
-          },
           "configurations": {
             "production": {
               "buildTarget": "ngx-progressbar-demo:build:production"
+            },
+            "development": {
+              "buildTarget": "ngx-progressbar-demo:build:development"
             }
-          }
+          },
+          "defaultConfiguration": "development"
         },
         "extract-i18n": {
           "builder": "@angular-devkit/build-angular:extract-i18n",
@@ -115,10 +84,12 @@
         "test": {
           "builder": "@angular-devkit/build-angular:karma",
           "options": {
-            "main": "projects/ngx-progressbar-demo/src/test.ts",
-            "polyfills": "projects/ngx-progressbar-demo/src/polyfills.ts",
+            "polyfills": [
+              "zone.js",
+              "zone.js/testing"
+            ],
             "tsConfig": "projects/ngx-progressbar-demo/tsconfig.spec.json",
-            "karmaConfig": "projects/ngx-progressbar-demo/karma.conf.js",
+            "inlineStyleLanguage": "scss",
             "assets": [
               "projects/ngx-progressbar-demo/src/favicon.ico",
               "projects/ngx-progressbar-demo/src/assets"
@@ -128,20 +99,56 @@
             ],
             "scripts": []
           }
-        },
-        "e2e": {
-          "builder": "@angular-devkit/build-angular:protractor",
+        }
+      }
+    },
+    "ngx-progressbar": {
+      "projectType": "library",
+      "root": "projects/ngx-progressbar",
+      "sourceRoot": "projects/ngx-progressbar/src",
+      "prefix": "lib",
+      "architect": {
+        "build": {
+          "builder": "@angular-devkit/build-angular:ng-packagr",
           "options": {
-            "protractorConfig": "projects/ngx-progressbar-demo/e2e/protractor.conf.js",
-            "devServerTarget": "ngx-progressbar-demo:serve"
+            "project": "projects/ngx-progressbar/ng-package.json"
           },
           "configurations": {
             "production": {
-              "devServerTarget": "ngx-progressbar-demo:serve:production"
+              "tsConfig": "projects/ngx-progressbar/tsconfig.lib.prod.json"
+            },
+            "development": {
+              "tsConfig": "projects/ngx-progressbar/tsconfig.lib.json"
             }
+          },
+          "defaultConfiguration": "production"
+        },
+        "test": {
+          "builder": "@angular-devkit/build-angular:karma",
+          "options": {
+            "tsConfig": "projects/ngx-progressbar/tsconfig.spec.json",
+            "polyfills": [
+              "zone.js",
+              "zone.js/testing"
+            ],
+            "karmaConfig": "projects/ngx-progressbar/karma.conf.js"
+          }
+        },
+        "lint": {
+          "builder": "@angular-eslint/builder:lint",
+          "options": {
+            "lintFilePatterns": [
+              "projects/ngx-progressbar/**/*.ts",
+              "projects/ngx-progressbar/**/*.html"
+            ]
           }
         }
       }
     }
+  },
+  "cli": {
+    "schematicCollections": [
+      "@angular-eslint/schematics"
+    ]
   }
 }
diff --git a/e2e/protractor.conf.js b/e2e/protractor.conf.js