Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating the add button and shop button #289

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

ak-0283
Copy link
Contributor

@ak-0283 ak-0283 commented Jan 10, 2025

Summary

In this update, I focused on resolving issues with the functionality and responsiveness of the "Add to Cart" button and the scroll button to enhance user interaction and improve the overall user experience on the website.

Key improvements made:

  1. Add to Cart Button:

    • Fixed the button functionality to ensure items are correctly added to the cart.
    • Resolved any UI/UX inconsistencies, such as button placement or visibility, across different devices and screen sizes.
    • Tested the button's behavior to ensure seamless interaction, including feedback upon clicking (e.g., animations or status messages).
  2. Scroll Button:

    • Corrected the behavior of the scroll button to ensure smooth scrolling to the desired section of the page.
    • Improved responsiveness and functionality across various browsers and devices.
    • Ensured the button's appearance and placement align with the overall design of the website.

Fixes #283

Type of Change

Here’s the updated template with the relevant items marked:


Type of Change

Please mark [X] for applicable items:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Code refactoring
  • Other (please describe):

Description of Changes

Provide a brief description of what changes were made and why:

  • Fixed the functionality of the "Add to Cart" button to ensure items are correctly added to the cart.
  • Resolved issues with the scroll button to enable smooth scrolling and alignment with the website's design.

Testing

Please describe the tests you performed to verify your changes:

  • Unit tests
  • Manual testing (describe steps below):

Screenshots/Videos

Screenshot 2025-01-10 164720


Checklist

Please mark [X] for completed items:

  • My code follows the project's style guidelines.
  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation accordingly.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • I have checked my code and ensured it is free of merge conflicts.

Copy link

vercel bot commented Jan 10, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
coffee-shop ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 10, 2025 11:24am

Copy link

Thank you for your contribution! 🎉

PR Checklist

  • Tests added/updated
  • Documentation updated
  • Changes follow coding standards
  • Commit messages are clear

Next Steps

  1. We will review your PR soon
  2. Address any requested changes
  3. Once approved, your PR will be merged

Need help? Check our Contributing Guide

Happy coding! 💻

@ak-0283
Copy link
Contributor Author

ak-0283 commented Jan 10, 2025

Please review and merge it. @Mujtabaa07

@Mujtabaa07 Mujtabaa07 added BEGINNER SWOC Social Winter Of Code labels Jan 10, 2025
@Mujtabaa07 Mujtabaa07 merged commit a8f1e19 into Mujtabaa07:main Jan 10, 2025
4 checks passed
@Mujtabaa07
Copy link
Owner

🎉 Congratulations on Your Merged PR!

Thank you @ak-0283 for your contribution!

What's Next?

Keep up the fantastic work! 🚀

@Mujtabaa07
Copy link
Owner

@ak-0283 I'm merging this pr next time add more functionality I'll assign you an advance or intermediate label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BEGINNER SWOC Social Winter Of Code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Duplicate 'Add to Cart' Buttons on Product Cards
2 participants