Skip to content
This repository has been archived by the owner on Jul 22, 2024. It is now read-only.

create thumbnail for WebVR Player (fixes issue #112) #176

Merged
merged 2 commits into from
Feb 28, 2018
Merged

create thumbnail for WebVR Player (fixes issue #112) #176

merged 2 commits into from
Feb 28, 2018

Conversation

cvan
Copy link
Contributor

@cvan cvan commented Feb 27, 2018

Fix #112

before

screen shot 2018-02-26 at 11 19 16 pm

after

screen shot 2018-02-26 at 11 18 32 pm


up close and personal

image

@cvan cvan self-assigned this Feb 27, 2018
@cvan cvan requested review from delapuente and caseyyee February 27, 2018 07:20
@cvan
Copy link
Contributor Author

cvan commented Feb 27, 2018

per the Unity docs, I created a file called thumbnail.png

the PNG here is 128×128 at 2x DPI (and compressed with pngquant)

@delapuente
Copy link
Contributor

I like it, @caseyyee do you have some aesthetic suggestion?

@cvan
Copy link
Contributor Author

cvan commented Feb 27, 2018

it is a little odd that the VR button is that visible when in VR mode (but that's what #130 will fix). but I think for now, most people won't notice or be bothered by that.

@caseyyee any issues with my merging this? it's definitely an improvement over the current icon lol (none!)

Copy link
Contributor

@caseyyee caseyyee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cvan go for it! will work on getting something a little more identifiable in there, but for now. this will do!

Thanks for doing this

@caseyyee
Copy link
Contributor

caseyyee commented Feb 27, 2018

@cvan you can use one of these.

If there is a specific size, could one that fits exactly too. looks like it might be a 1:1 aspect?

icon
large
small

One with a browser window
social

@caseyyee
Copy link
Contributor

image

256x256 as per slack w/ browser window

@cvan
Copy link
Contributor Author

cvan commented Feb 28, 2018

thanks, @caseyyee!


for posterity's sake: see the source files for these icons produced by @caseyyee:

webvr-asset-store-icons.zip

original icon sent via Slack (548×548)

thumbnail (256×256)

@cvan
Copy link
Contributor Author

cvan commented Feb 28, 2018

branch updated!

screen shot 2018-02-27 at 6 19 59 pm

thanks, @caseyyee - it looks great 👍

@cvan cvan merged commit 949d994 into MozillaReality:master Feb 28, 2018
@cvan cvan added this to the Polished community release milestone Feb 28, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve the icon for the "WebVR" Player in Player Settings
3 participants