SQLite Storage Option #14
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements another option for storing the data. Currently, one of the pain points of flat files is that FTP/SFTP transfer of the files take a long time. When moving server files around, it's often that transferring the data takes up a significant portion of the time. However, with MySQL most shared providers have limited amount of SQL databases you can create, so if existing plugins already require it, then you don't be about to use the MySQL storage. Additionally, it would be nice to have a self-contained storage like SQLite instead of having to rely on a separate database server.
The plugin still makes the http call to check for the update even while the update checker setting is turned off. It just won't display the result. Moved the check off the main thread or else the server will stall when there's something wrong with the http connection. If there is slow connection or the spigot website is down, the server will stall or crash.
|
Oops, should have opened a new branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements another option for storing the data.
Currently, one of the pain points of flat files is that FTP/SFTP transfer of the files take a long time. When moving server files around, it's often that transferring the data takes up a significant portion of the time.
However, with MySQL most shared providers have limited amount of SQL databases you can create, so if existing plugins already require it, then you don't be about to use the MySQL storage. Additionally, it would be nice to have a self-contained storage like SQLite instead of having to rely on a separate database server.