Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrating Screenkey for key capturing #27

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

peteruithoven
Copy link
Collaborator

Fixing: #26

@peteruithoven
Copy link
Collaborator Author

@Mohelm97 what do you think about this idea?
Would it be an issue to include screenkey as a default dependency?

@peteruithoven peteruithoven marked this pull request as ready for review April 24, 2019 21:43
@Mohelm97
Copy link
Owner

@peteruithoven Well, that was soo fast :D Thanks a lot mate,
I think it's a good idea until we write something else, I will test it tomorrow and see how it looks like <3

@Mohelm97
Copy link
Owner

@peteruithoven It's awesome, and I don't know why I need to unset XMODIFIERS to make it works, see this issue wavexx/screenkey#36, and what do you think about showing only modifier sequences?

@peteruithoven
Copy link
Collaborator Author

I still need to do that as well, I totally forgot about that issue I just opened a new question on stack exchange: https://elementaryos.stackexchange.com/questions/18810/running-screenkey-on-elementary-os

One of the biggest risks in integrating this into Screen Recorder is that we might get a lot of screenkey related issues reported to us. Like this Cannot initialize input method issue.

@peteruithoven
Copy link
Collaborator Author

I've reopened and updated this old issue of mine: https://github.com/elementary/gala/issues/27

@peteruithoven
Copy link
Collaborator Author

I should try overriding environment variables for screenkey by using SubprocessLauncher.

@peteruithoven
Copy link
Collaborator Author

Temporary workaround:

unset XMODIFIERS
unset GTK_IM_MODULES
unset QT_IM_MODULES
com.github.mohelm97.screenrecorder

@peteruithoven
Copy link
Collaborator Author

While reading other issues this comment from @ryonakano caught my attention:

elementary OS uses IBus out of the box, but it does not start IBus daemon.

elementary/switchboard-plug-keyboard#231 (comment)

Looks like screenkey works just file after starting: ibus-daemon -drx.

@Mohelm97
Copy link
Owner

Mohelm97 commented Aug 4, 2019

@peteruithoven So instead of unsetting stuff, we can run the ibus daemon? cool
I'm working now (offline) on an advance options screen so we can add the screenkey, changing the background, circling the cursor, and the gif encoding in it, so get ready :D

@ryonakano
Copy link
Contributor

I personally think running IBus Daemon should be handled by the OS itself: the OS should start IBus Daemon automatically even in any language. As far as I confirmed on Ubuntu 18.04 (en_US) Ubuntu does this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants