Remove Enderal settings & Add ParticleLights to valid data directories #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Holt59
reviewed
May 15, 2024
| @@ -198,8 +198,7 @@ MOBase::VersionInfo GameSkyrimSE::version() const | |||
|
|
|||
| QList<PluginSetting> GameSkyrimSE::settings() const | |||
| { | |||
| return {PluginSetting("enderal_downloads", "allow Enderal and Enderal SE downloads", | |||
| QVariant(false))}; | |||
| return {}; //Must return something, otherwise linker erros smh | |||
There was a problem hiding this comment.
You obviously needs to return an empty list in a function that as a QList return type so that comment is not really useful.
Holt59
reviewed
May 15, 2024
|
This should be two separate PR (Enderal stuff and Particle Lights). Regarding the Enderal stuff, the fact that is used for short names means that users can opt-in or opt-out allowing downloads from Enderal and Enderal SE on Nexus. Having it turned-off by default prevent users from downloading from the wrong side. So I'm not for removing the settings. Regarding the need for Enderal/EnderalSE downloads on Skyrim, I'll refer you to the original PR #23 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Authors
Motivations
ParticleLightsis a valid mod data directory